-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Asset graph] Add animations for in progress / queued materialization state #20556
Conversation
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 2632512. |
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 2632512. |
// Check if the input string is in the correct format | ||
const rgbaRegex = /^rgba?\((\s*\d+\s*),(\s*\d+\s*),(\s*\d+\s*),(\s*[\d.]+\s*)\)$/; | ||
const match = rgbaString.match(rgbaRegex); | ||
if (!match) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to also require match.length === 3 or 4 here, just in case since it's required on lines 21-23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the regex requires that by the number of matches in it
… state (#20556) ## Summary & Motivation https://github.com/dagster-io/dagster/assets/2286579/eaa4be22-a8ac-4155-be4b-606bf0164593 # Test plan: Storybook: https://dagit-core-storybook-78f45n3pp-elementl.vercel.app/?path=/story/asset-graph-assetnode--live-states
… state (#20556) ## Summary & Motivation https://github.com/dagster-io/dagster/assets/2286579/eaa4be22-a8ac-4155-be4b-606bf0164593 # Test plan: Storybook: https://dagit-core-storybook-78f45n3pp-elementl.vercel.app/?path=/story/asset-graph-assetnode--live-states
Summary & Motivation
Screen.Recording.2024-03-19.at.9.50.38.AM.mov
Test plan:
Storybook: https://dagit-core-storybook-78f45n3pp-elementl.vercel.app/?path=/story/asset-graph-assetnode--live-states