Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Asset graph] Add animations for in progress / queued materialization state #20556

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

salazarm
Copy link
Contributor

@salazarm salazarm commented Mar 19, 2024

Summary & Motivation

Screen.Recording.2024-03-19.at.9.50.38.AM.mov

Test plan:

Storybook: https://dagit-core-storybook-78f45n3pp-elementl.vercel.app/?path=/story/asset-graph-assetnode--live-states

Copy link

github-actions bot commented Mar 19, 2024

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-mvcu4k218-elementl.vercel.app
https://salazarm-node-materializing-state.components-storybook.dagster-docs.io

Built with commit 2632512.
This pull request is being automatically deployed with vercel-action

Copy link

github-actions bot commented Mar 19, 2024

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-g58ncb7kq-elementl.vercel.app
https://salazarm-node-materializing-state.core-storybook.dagster-docs.io

Built with commit 2632512.
This pull request is being automatically deployed with vercel-action

// Check if the input string is in the correct format
const rgbaRegex = /^rgba?\((\s*\d+\s*),(\s*\d+\s*),(\s*\d+\s*),(\s*[\d.]+\s*)\)$/;
const match = rgbaString.match(rgbaRegex);
if (!match) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to also require match.length === 3 or 4 here, just in case since it's required on lines 21-23

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the regex requires that by the number of matches in it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants