[ui] Fix theming on breadcrumb popover #21267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hellendag and the rest of your teammates on |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit b2dfd14. |
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 09ed1a8. |
hellendag
force-pushed
the
dish/fe-296-popover-needs-dark-mode
branch
from
09ed1a8 to
b2dfd14
Compare
nikomancy
pushed a commit
to nikomancy/dagster
that referenced
this pull request
May 1, 2024
## Summary & Motivation The Blueprint Breadcrumb component needed to have the `dagster-popover` class applied to it to get themed styles. By changing to the newer `Breadcrumbs2` (as suggested by Blueprint deprecation) we get the bp4 targeted classnames that are already in place on our existing popovers, and the styles just work. <img width="234" alt="Screenshot 2024-04-17 at 13 53 10" src="https://github.com/dagster-io/dagster/assets/2823852/3c3cee87-17a0-4aa1-b048-84c6d234065f"> <img width="229" alt="Screenshot 2024-04-17 at 13 52 54" src="https://github.com/dagster-io/dagster/assets/2823852/16be9b2d-eeaf-4605-a6fc-cba39467f919"> ## How I Tested These Changes Force breadcrumbs to appear on asset page header, click on breadcrumb popover button. Verify themed styling matches the app in both light and dark mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The Blueprint Breadcrumb component needed to have the
dagster-popoverclass applied to it to get themed styles. By changing to the newerBreadcrumbs2(as suggested by Blueprint deprecation) we get the bp4 targeted classnames that are already in place on our existing popovers, and the styles just work.How I Tested These Changes
Force breadcrumbs to appear on asset page header, click on breadcrumb popover button. Verify themed styling matches the app in both light and dark mode.