[ui] Use Geist Mono instead of Inconsolata #21317
Conversation
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hellendag and the rest of your teammates on |
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit d25e3b4. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit d25e3b4. |
There was a problem hiding this comment.
This looks awesome! I thought we were planning to move to Roboto and Roboto mono though? (Though that was two weeks ago...) Guess this is easier since it's just the monospace font that has to change.
Also agree re: long tail of fixes, we should just merge this and be on the lookout for more oddly sized text 👀
| @@ -315,7 +315,7 @@ export const NameTooltipCSS: CSSObject = { | |||
| ...NameCSS, | |||
| top: -9, | |||
| left: -12, | |||
| fontSize: 16.8, | |||
| fontSize: 14, | |||
There was a problem hiding this comment.
Haha man... love to see it 😂
## Summary & Motivation Replace Inconsolata with Geist Mono throughout the app. This is a step toward better consistency with our typefaces, in particular eliminating the font-size hacks we've had to use to make Inter and Inconsolata work well together. I've gone through and eliminated or fixed a number of these font-size hacks, but we'll probably have a long tail of cleanup to do to get them all. <img width="1415" alt="Screenshot 2024-04-19 at 16 05 21" src="https://github.com/dagster-io/dagster/assets/2823852/5d831848-9277-47d2-bbf7-ced30f90da11"> <img width="1413" alt="Screenshot 2024-04-19 at 16 05 47" src="https://github.com/dagster-io/dagster/assets/2823852/9bb1a8a7-9fb5-41cc-b7d3-60870658ec7f"> <img width="1034" alt="Screenshot 2024-04-19 at 16 05 56" src="https://github.com/dagster-io/dagster/assets/2823852/4ea8aa54-3b73-4dbc-bf36-27b364fb58f9"> <img width="584" alt="Screenshot 2024-04-19 at 16 06 15" src="https://github.com/dagster-io/dagster/assets/2823852/13af4673-2b20-43e9-8fce-ea4f5bb84a31"> <img width="520" alt="Screenshot 2024-04-19 at 16 06 37" src="https://github.com/dagster-io/dagster/assets/2823852/cabe71ca-3bb5-4605-8f1a-e9340ffad81b"> ## How I Tested These Changes Navigate around the app, verify that fonts look correct.
Summary & Motivation
Replace Inconsolata with Geist Mono throughout the app. This is a step toward better consistency with our typefaces, in particular eliminating the font-size hacks we've had to use to make Inter and Inconsolata work well together.
I've gone through and eliminated or fixed a number of these font-size hacks, but we'll probably have a long tail of cleanup to do to get them all.
How I Tested These Changes
Navigate around the app, verify that fonts look correct.