[ui] Show tooltips on metadata entries explaining the data origin #21322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 73b7054. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 73b7054. |
salazarm
approved these changes
Apr 21, 2024
nikomancy
pushed a commit
to nikomancy/dagster
that referenced
this pull request
May 1, 2024
…gster-io#21322) ## Summary & Motivation Fixes FE-215 This adds tooltips that make it more obvious that the asset overview's metadata table is combining metadata from different sources. Previously you had to look at the icons and understand what they meant: <img width="585" alt="image" src="https://github.com/dagster-io/dagster/assets/1037212/4676c84e-a737-42e9-888b-f6cff60d6cc9"> I also fixed some CSS issues with nested tables here. The CSS for the asset metadata table (the outer one) was colliding with the styles of the inner nested table, giving it double borders. I also applied the compact style to the inner one, which I think looks better. <img width="1208" alt="image" src="https://github.com/dagster-io/dagster/assets/1037212/97e1666a-3c9a-442c-baab-68ed1e692818"> <img width="1210" alt="image" src="https://github.com/dagster-io/dagster/assets/1037212/66319039-c665-4fba-b39c-f277cd5df17a"> ## How I Tested These Changes --------- Co-authored-by: bengotow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Fixes FE-215
This adds tooltips that make it more obvious that the asset overview's metadata table is combining metadata from different sources. Previously you had to look at the icons and understand what they meant:
I also fixed some CSS issues with nested tables here. The CSS for the asset metadata table (the outer one) was colliding with the styles of the inner nested table, giving it double borders. I also applied the compact style to the inner one, which I think looks better.
How I Tested These Changes