Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Monospace font fixes in oss #21339

Merged
merged 1 commit into from
Apr 22, 2024
Merged

[ui] Monospace font fixes in oss #21339

merged 1 commit into from
Apr 22, 2024

Conversation

hellendag
Copy link
Member

@hellendag hellendag commented Apr 22, 2024

Summary & Motivation

A handful of font size fixes for monospace, now that Geist Mono is in place.

How I Tested These Changes

View each of these areas of the app, verify intended font sizes.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hellendag and the rest of your teammates on Graphite Graphite

@hellendag hellendag marked this pull request as ready for review April 22, 2024 18:25
Copy link

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-h3dh4102t-elementl.vercel.app
https://dish-monospace-fixes.core-storybook.dagster-docs.io

Built with commit e5033c2.
This pull request is being automatically deployed with vercel-action

Copy link

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-8bsnbzo4h-elementl.vercel.app
https://dish-monospace-fixes.components-storybook.dagster-docs.io

Built with commit e5033c2.
This pull request is being automatically deployed with vercel-action

@hellendag hellendag merged commit 18a63af into master Apr 22, 2024
3 checks passed
@hellendag hellendag deleted the dish/monospace-fixes branch April 22, 2024 20:05
nikomancy pushed a commit to nikomancy/dagster that referenced this pull request May 1, 2024
## Summary & Motivation

A handful of font size fixes for monospace, now that Geist Mono is in
place.

## How I Tested These Changes

View each of these areas of the app, verify intended font sizes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants