Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Upgrade TS to 5.4.5 #21347

Merged
merged 1 commit into from
Apr 23, 2024
Merged

[ui] Upgrade TS to 5.4.5 #21347

merged 1 commit into from
Apr 23, 2024

Conversation

hellendag
Copy link
Member

@hellendag hellendag commented Apr 22, 2024 •
edited
Loading

Summary & Motivation

Bump TS to 5.4.5 to match vscode.

How I Tested These Changes

Buildkite

@hellendag Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hellendag and the rest of your teammates on Graphite Graphite

@hellendag hellendag requested review from bengotow and salazarm April 22, 2024 20:28
@hellendag hellendag marked this pull request as ready for review April 22, 2024 20:28
@graphite-app graphite-app bot requested a review from erinkcochran87 April 22, 2024 20:28
@graphite-app graphite-app bot added the area: docs Related to documentation in general label Apr 22, 2024
@github-actions GitHub Actions
Copy link

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-4sziiscah-elementl.vercel.app
https://dish-oss-ts.core-storybook.dagster-docs.io

Built with commit 48ee01f.
This pull request is being automatically deployed with vercel-action

@github-actions GitHub Actions
Copy link

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-q97ap2h16-elementl.vercel.app
https://dish-oss-ts.components-storybook.dagster-docs.io

Built with commit 48ee01f.
This pull request is being automatically deployed with vercel-action

@github-actions GitHub Actions
Copy link

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-bzxgw6zpj-elementl.vercel.app
https://dish-oss-ts.dagster.dagster-docs.io

Direct link to changed pages:

@hellendag hellendag merged commit bc28885 into master Apr 23, 2024
4 checks passed
@hellendag hellendag deleted the dish/oss-ts branch April 23, 2024 14:01
nikomancy pushed a commit to nikomancy/dagster that referenced this pull request May 1, 2024
@hellendag @nikomancy
[ui] Upgrade TS to 5.4.5 (dagster-io#21347)
5ee8998 
## Summary & Motivation

Bump TS to 5.4.5 to match vscode.

## How I Tested These Changes

Buildkite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salazarm salazarm salazarm approved these changes

@bengotow bengotow Awaiting requested review from bengotow

@erinkcochran87 erinkcochran87 Awaiting requested review from erinkcochran87

Assignees
No one assigned
Labels
area: docs Related to documentation in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hellendag @salazarm