Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit hidden_param #22389

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Explicit hidden_param #22389

merged 1 commit into from
Jun 22, 2024

Conversation

schrockn
Copy link
Member

@schrockn schrockn commented Jun 8, 2024 •
edited
Loading

Summary & Motivation

A further extension to #22385, this proposes making an explicit hidden_param rather just a boolean flag on deprecated_param.

Two reasons why this could be a good idea.

  1. This is more greppable. We could audit our uses of hidden versus deprecated trivially, rather than having to inspect every callsite.
  2. We could use hidden params for the experimental use case as well, as a way to introduce capabilities in our releases without polluting public signatures.

I think #2 potentially pretty compelling. I'm not super high conviction on this but writing this out made my think this is the right approach.

How I Tested These Changes

BK

@schrockn schrockn mentioned this pull request Jun 8, 2024
Closed
@schrockn Graphite App
Copy link
Member Author

schrockn commented Jun 8, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @schrockn and the rest of your teammates on Graphite Graphite

@schrockn schrockn mentioned this pull request Jun 8, 2024
Merged
@schrockn schrockn force-pushed the explicit-hidden-param-decorator branch from 3393461 to 0618a93 Compare June 22, 2024 14:41
@schrockn schrockn changed the base branch from hide-dbt-manifest-args to hide-super-deprecated-arg June 22, 2024 14:41
@schrockn schrockn merged commit 0618a93 into hide-super-deprecated-arg Jun 22, 2024
3 of 4 checks passed
@schrockn schrockn deleted the explicit-hidden-param-decorator branch June 22, 2024 14:41
@github-actions GitHub Actions
Copy link

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-qtihfv9hg-elementl.vercel.app
https://explicit-hidden-param-decorator.components-storybook.dagster-docs.io

Built with commit 0618a93.
This pull request is being automatically deployed with vercel-action

@github-actions GitHub Actions
Copy link

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-qkhz0c1jc-elementl.vercel.app
https://explicit-hidden-param-decorator.core-storybook.dagster-docs.io

Built with commit 0618a93.
This pull request is being automatically deployed with vercel-action

@github-actions GitHub Actions
Copy link

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-pog3ri4np-elementl.vercel.app
https://explicit-hidden-param-decorator.dagster.dagster-docs.io

Direct link to changed pages:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@schrockn