Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] show applyLimitPerUniqueValue entries in queue criteria #22536

Merged
merged 1 commit into from
Jun 14, 2024
Merged

[ui] show applyLimitPerUniqueValue entries in queue criteria #22536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions js_modules/dagster-ui/packages/ui-core/src/runs/QueuedRunCriteriaDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
Tag,
Tooltip,
} from '@dagster-io/ui-components';
import isPlainObject from 'lodash/isPlainObject';
import * as React from 'react';
import {Link} from 'react-router-dom';
import * as yaml from 'yaml';
Expand Down Expand Up @@ -66,7 +67,10 @@ const QueuedRunCriteriaDialogContent = ({run}: {run: RunTableRunFragment}) => {
return limits.filter(
(limit) =>
limit.key in runTagMap &&
(limit.value === undefined || limit.value === runTagMap[limit.key]),
(limit.value === undefined ||
limit.value === runTagMap[limit.key] ||
// can be {"applyLimitPerUniqueValue": bool}
isPlainObject(limit.value)),
);
} catch (err) {
return undefined;
Expand Down Expand Up @@ -119,7 +123,9 @@ const QueuedRunCriteriaDialogContent = ({run}: {run: RunTableRunFragment}) => {
</td>
<td>
<Tag interactive>
{limit.value !== undefined ? `${limit.key}=${limit.value}` : limit.key}
{limit.value !== undefined
? `${limit.key}=${JSON.stringify(limit.value)}` // might be obj so stringify
: limit.key}
</Tag>
</td>
</tr>
Expand Down
Loading