[graphql] instigation state by id #22543
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alangenfeld and the rest of your teammates on |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit e1a9fa7. |
| @@ -281,13 +288,22 @@ class Meta: | |||
|
|
|||
| instigationStateOrError = graphene.Field( | |||
| graphene.NonNull(GrapheneInstigationStateOrError), | |||
| instigationSelector=graphene.NonNull(GrapheneInstigationSelector), | |||
| instigationSelector=graphene.Argument(GrapheneInstigationSelector), | |||
| id=graphene.Argument(graphene.String), | |||
There was a problem hiding this comment.
Can this take an array of Ids instead so that I can use our batching abstraction :)
There was a problem hiding this comment.
i can on the "states" resolver -I need to add the database look impl for many by id so will be a stacked PR. Thought maybe converting "SingleXQuery` in place would be the move but I can see wanting to move to batching while we are changing things
There was a problem hiding this comment.
I don't mind keeping individual queries. It's likely faster since theres more parallelization, but also slight more taxing on the server. gcpu vs ux latency trade off
alangenfeld
force-pushed
the
al/06-13-_graphql_instigation_state_by_id
branch
3 times, most recently
from
3c8fe6c to
3677301
Compare
alangenfeld
force-pushed
the
al/06-13-_graphql_instigation_state_by_id
branch
from
3677301 to
0b0fc9c
Compare
|
|
||
|
|
||
| @dagster_model | ||
| class CompoundID: |
There was a problem hiding this comment.
this name feels a little generic considering it's specific to instigators.
There was a problem hiding this comment.
Repository uses it too which is why i dropped instigator framing
open to other names tho
There was a problem hiding this comment.
CompoundExternalId
OriginAndSelectorId
meh, not user facing / changeable in the future since not persisted
alangenfeld
force-pushed
the
al/06-13-_graphql_instigation_state_by_id
branch
from
0b0fc9c to
1d08104
Compare
|
|
||
|
|
||
| @dagster_model | ||
| class CompoundID: |
There was a problem hiding this comment.
CompoundExternalId
OriginAndSelectorId
meh, not user facing / changeable in the future since not persisted
alangenfeld
force-pushed
the
al/06-13-_graphql_instigation_state_by_id
branch
from
1d08104 to
e1a9fa7
Compare
CompoundIDto wrap external origin + selector id componentsScheduleSensorandRepositoryid fields to return serialized CompoundIDsinstigationStateOrErrorto be able to fetch by idinstigationStatesOrErrorand support fetching all instigation states by their containing repository IDHow I Tested These Changes
Added tests