Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Upgrade Storybook, repair dependabot alerts #22679

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

hellendag
Copy link
Member

@hellendag hellendag commented Jun 24, 2024

Summary & Motivation

Upgrade Storybook to v8 to resolve some dependency issues, and handle a few others manually.

How I Tested These Changes

Buildkite.

yarn storybook in both ui-core and ui-components, verify success.

yarn why to sanity check that packages flagged by dependabot have been updated.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hellendag and the rest of your teammates on Graphite Graphite

@hellendag hellendag requested review from bengotow and salazarm June 24, 2024 16:50
@hellendag hellendag marked this pull request as ready for review June 24, 2024 16:50
Copy link

github-actions bot commented Jun 24, 2024

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-qqnc15adx-elementl.vercel.app
https://dish-oss-storybook-and-dependabot.components-storybook.dagster-docs.io

Built with commit 0394d28.
This pull request is being automatically deployed with vercel-action

@hellendag hellendag force-pushed the dish/oss-storybook-and-dependabot branch from 229fb7b to 4aefde3 Compare June 24, 2024 18:13
@hellendag hellendag force-pushed the dish/oss-storybook-and-dependabot branch 3 times, most recently from 18ba627 to ebb1311 Compare June 25, 2024 16:39
@hellendag
Copy link
Member Author

I think the Storybook build is ooming on the Vercel deployment, but I'm not sure why. I'll come back to this.

@salazarm
Copy link
Contributor

Doesn't repro locally?

@hellendag
Copy link
Member Author

Nope, it's fine locally. Not super fast, but fine.

@hellendag hellendag force-pushed the dish/oss-storybook-and-dependabot branch from ebb1311 to 0394d28 Compare June 26, 2024 14:49
Copy link

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-m0s8phreg-elementl.vercel.app
https://dish-oss-storybook-and-dependabot.core-storybook.dagster-docs.io

Built with commit 0394d28.
This pull request is being automatically deployed with vercel-action

@hellendag hellendag merged commit f88e490 into master Jun 26, 2024
3 checks passed
@hellendag hellendag deleted the dish/oss-storybook-and-dependabot branch June 26, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants