[ui] Ability to report asset materializations from the actions dropdown #22691
+110
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 796a8af. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 796a8af. |
bengotow
changed the title
bengotow
changed the title
- The “All keys” dropdown looks like our other dropdowns (it’s a typeahead that is also a dropdown) - The experimental banner is gone! - Check tag names truncate correctly - The checks that have failed appear in a popover - The tabs have been revamped to match the new designs - The dropdown (Actually all Asset dropdowns) now allow for Report Materialization and View Checks. - The loading state now says “Evaluating” instead of “Scanning” - The empty state now has a spinning daggy on all three tabs except executing, which uses a standard non-ideal state to show the CTA to the catalog page. - Code location and group are now two separate columns, which allows the table to be 56 instead of 64px per row. Remaining: - Product tour - Ability to limit failures to a time range. This is possible for check failures / execution failures until they are partitioned, and then it’s pretty much impossible on top of our current GraphQL schema :(
bengotow
force-pushed
the
bengotow-2024-06/FE-397
branch
from
6fce698 to
796a8af
Compare
salazarm
approved these changes
Jun 25, 2024
bengotow
added a commit
that referenced
this pull request
Jul 3, 2024
…wn [2] (#22781) This is a second pass at merging #22691 -- I merged it earlier this week without realizing the internal PR (dagster-io/internal#10341) still had a buildkite error on it, and they need to merge together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related https://linear.app/dagster-labs/issue/FE-397/asset-health-polish
Check tag names truncate correctly
The checks that have failed appear in a popover
Asset dropdowns now allow for Report Materialization and View Checks.