[DbtProject] Rename --use-experimental-dbt-project flag to --use-dbt-project in dbt scaffold CLI
#22794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maximearmstrong and the rest of your teammates on |
maximearmstrong
changed the title
--use-experimental-dbt-project flag by --use-dbt-project in dbt scaffold CLI--use-experimental-dbt-project flag by --use-dbt-project in dbt scaffold CLI
maximearmstrong
changed the title
--use-experimental-dbt-project flag by --use-dbt-project in dbt scaffold CLI--use-experimental-dbt-project flag to --use-dbt-project in dbt scaffold CLI
rexledesma
approved these changes
Jul 2, 2024
Comment on lines
249
to
253
| use_experimental_dbt_project: Annotated[ | ||
| use_dbt_project: Annotated[ | ||
| bool, | ||
| typer.Option( | ||
| ..., | ||
| "--use-experimental-dbt-project", |
There was a problem hiding this comment.
Can also just keep --use-experimental-dbt-project as a flag so things that use that flag won't break (e.g. extraneous docs, internal).
@rexledesma It's ready for review here |
|
Sweet thanks |
maximearmstrong
force-pushed
the
maxime/ds-334/update-flag-to-use-dbt-project
branch
from
b3a685a to
de0a2ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR renames the
--use-experimental-dbt-projectflag to--use-dbt-projectin the dbt scaffold CLI, now that DbtProject is no more experimental.This is the first step in making DbtProject the default and only strategy when scaffolding a dbt project. The goal is to facilitate the transition from the previous default strategy to that of DbtProject in our tutorials, courses and docs.
Once this is merged, next steps will be to
dagster-dbt project scaffold --use-dbt-projectwith the updated flagdagster-dbt project scaffoldTickets are listed here.
How I Tested These Changes
BK with updated tests