Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][guide] approaches to writing integrations #22903

Merged
merged 5 commits into from
Aug 23, 2024
Merged

[docs][guide] approaches to writing integrations #22903

merged 5 commits into from
Aug 23, 2024

Conversation

cmpadden
Copy link
Contributor

@cmpadden cmpadden commented Jul 9, 2024 •
edited
Loading

  • Introduces a landing page for guides on writing integrations, currently outlined include:
    • asset factory
    • multi-asset decorator
    • resource definitions
    • pipes

@cmpadden Graphite App
Copy link
Contributor Author

cmpadden commented Jul 9, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @cmpadden and the rest of your teammates on Graphite Graphite

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-dscol75ot-elementl.vercel.app
https://colton-guide-integration-approaches.dagster.dagster-docs.io

Direct link to changed pages:

@cmpadden cmpadden mentioned this pull request Jul 9, 2024
Merged
@cmpadden cmpadden marked this pull request as ready for review July 12, 2024 17:28
@graphite-app graphite-app bot added the area: docs Related to documentation in general label Jul 12, 2024
@graphite-app graphite-app bot requested a review from erinkcochran87 July 12, 2024 17:28
@cmpadden cmpadden force-pushed the colton/guide-integration-approaches branch from 0533f7b to b286464 Compare July 12, 2024 18:18
@cmpadden cmpadden requested a review from PedramNavid July 23, 2024 16:54
@cmpadden cmpadden force-pushed the colton/guide-integration-approaches branch from 11fdb33 to 950746f Compare July 26, 2024 13:56
@cmpadden cmpadden force-pushed the colton/guide-integration-approaches branch from 950746f to 6561292 Compare August 8, 2024 17:16
yuhan
yuhan reviewed Aug 20, 2024
View reviewed changes
Copy link
Contributor

@yuhan yuhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apologies for the long overdue review. this looks amazing. i left some suggestions in comments, but overall lg(great)2m

docs/content/guides/integrations/approaches-to-writing-integrations.mdx Outdated Show resolved Hide resolved
docs/content/guides/integrations/approaches-to-writing-integrations.mdx Show resolved Hide resolved
docs/content/guides/integrations/approaches-to-writing-integrations.mdx Show resolved Hide resolved
docs/content/guides/integrations/approaches-to-writing-integrations.mdx Outdated Show resolved Hide resolved
@cmpadden Graphite App
Copy link
Contributor Author

cmpadden commented Aug 23, 2024 •
edited
Loading

Merge activity

  • Aug 23, 2:46 PM EDT: @cmpadden started a stack merge that includes this pull request via Graphite.
  • Aug 23, 2:50 PM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 23, 2:52 PM EDT: Graphite rebased this pull request as part of a merge.

@cmpadden cmpadden force-pushed the colton/guide-integration-approaches branch from 6787333 to d22ec59 Compare August 23, 2024 18:49
@cmpadden cmpadden force-pushed the colton/guide-integration-approaches branch from d22ec59 to ccd8214 Compare August 23, 2024 18:51
@cmpadden cmpadden merged commit fc81cf5 into master Aug 23, 2024
2 of 3 checks passed
@cmpadden cmpadden deleted the colton/guide-integration-approaches branch August 23, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhan yuhan yuhan approved these changes

@erinkcochran87 erinkcochran87 Awaiting requested review from erinkcochran87

@PedramNavid PedramNavid Awaiting requested review from PedramNavid

@maximearmstrong maximearmstrong Awaiting requested review from maximearmstrong

Assignees
No one assigned
Labels
area: docs Related to documentation in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmpadden @PedramNavid @yuhan