[ui] Use newer virtualizer for Suggest #22972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hellendag and the rest of your teammates on |
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 2509173. |
hellendag
force-pushed
the
dish/fix-components-build
branch
from
58a1791 to
bce95e0
Compare
hellendag
force-pushed
the
dish/suggest-list
branch
from
692fa55 to
40023a9
Compare
salazarm
approved these changes
Jul 16, 2024
Merge activity
|
hellendag
force-pushed
the
dish/fix-components-build
branch
from
bce95e0 to
6d0ca90
Compare
hellendag
force-pushed
the
dish/suggest-list
branch
from
40023a9 to
2509173
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Replace
react-virtualizedwith the tanstack virtualizer in the Suggest component. This eliminatesreact-virtualizedas a peer dep inui-components.How I Tested These Changes
View
Suggeststorybook example, verify correct rendering and behavior of input, list, list items. Includes hovering, clicking, keyboard navigation and selecting.View use cases of
Suggestin the app, verify same: launchpad config partition picker, asset graph sidebar search, compute log toolbar filter.