[docs] - Update Dagster+ CI/CD files into single deploy.yml #23035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erinkcochran87
commented
Jul 16, 2024
| <a href="/dagster-plus/managing-deployments/branch-deployments"> | ||
| Branch Deployments | ||
| </a>{" "} | ||
| (For Dagster+ accounts created after [TODO]) |
There was a problem hiding this comment.
Replace with date when we have it
erinkcochran87
commented
Jul 16, 2024
| </li> | ||
| </ul> | ||
| Defines the steps required to use Branch Deployments.{" "} | ||
| <strong>For Dagster+ accounts created after [TODO]</strong>, the |
There was a problem hiding this comment.
Replace with date when we have it
erinkcochran87
commented
Jul 16, 2024
| <TabItem name="Using GitHub Actions"> | ||
|
|
||
| <Note> | ||
| <strong>Heads up!</strong> If your Dagster+ account was created before [TODO], |
There was a problem hiding this comment.
Replace with date when we have it
erinkcochran87
commented
Jul 16, 2024
| @@ -408,11 +414,15 @@ height={537} | |||
| <TabGroup> | |||
| <TabItem name="Using GitHub Actions"> | |||
|
|
|||
| Finally, we can add a step to our `branch_deployments.yml` file that queues a run of our `drop_prod_clone` job: | |||
| <Note> | |||
| <strong>Heads up!</strong> If your Dagster+ account was created before [TODO], | |||
There was a problem hiding this comment.
Replace with date when we have it
graphite-app
bot
added
the
area: dagster-university
erinkcochran87
commented
Jul 16, 2024
| @@ -220,7 +218,7 @@ The last step is to update the [CI/CD files](/dagster-plus/references/ci-cd-file | |||
|
|
|||
| 5. Save the changes. | |||
|
|
|||
| 6. Open the `branch_deployments.yml` file and repeat steps 3 - 5. | |||
| 6. **If your Dagster+ account was created before \[TODO]**, open the `branch_deployments.yml` file and repeat steps 3 - 5. | |||
There was a problem hiding this comment.
Replace with date when we have it
erinkcochran87
commented
Jul 16, 2024
| @@ -32,6 +32,8 @@ When Dagster deploys the code, a few things happen: | |||
| - `.github/workflows/deploy.yml` - This file sets up Continuous Deployment (CD) for the repository. We won’t talk through all the steps here, but a high-level summary is that every time a change is made to the `main` branch of your repository, this GitHub Action will build your Dagster project and deploy it to Dagster+. | |||
| - `.github/workflows/branch_deployments.yml` - This file enables the use of [Branch Deployments](https://docs.dagster.io/dagster-cloud/managing-deployments/branch-deployments), a Dagster+ feature that automatically creates staging environments for your Dagster code with every pull request. We won’t work with Branch Deployments during this lesson, but we highly recommend trying them out! | |||
|
|
|||
| **Note**: This file is only created if your Dagster+ account was created before [TODO]. If your account was created on or after this date, the `branch_deployments.yml` file will be consolidated into `deploy.yml`. | |||
There was a problem hiding this comment.
Replace with date when we have it
|
Deploy preview for dagster-university ready! ✅ Preview Built with commit 0e97f90. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR updates the docs to reflect the changes in dagster-io/dagster-cloud-action#187 and dagster-io/dagster-cloud-action#188. Serverless deployments will now have a single
deploy.ymlfor GitHub Actions, matching Hybrid.How I Tested These Changes