Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add more explanation for FilePathMapping for code references #23385

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

benpankow
Copy link
Member

@benpankow benpankow commented Aug 2, 2024

Summary

Adds .rst entry and link to apidoc for file path mapping objects, since this is probably the most confusing part of mapping to source control.

Test Plan

Vercel preview.

@graphite-app graphite-app bot requested a review from erinkcochran87 August 2, 2024 18:30
@graphite-app graphite-app bot added the area: docs Related to documentation in general label Aug 2, 2024
@benpankow
Copy link
Member Author

benpankow commented Aug 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benpankow and the rest of your teammates on Graphite Graphite

@benpankow benpankow requested a review from sryza August 2, 2024 18:38
Copy link
Contributor

@erinkcochran87 erinkcochran87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a suggestion that fixes a typo in PyObject, but otherwise this lgtm!

docs/content/guides/dagster/code-references.mdx Outdated Show resolved Hide resolved
@benpankow benpankow force-pushed the benpankow/adjust-mapping-docs branch from 06909d8 to 4582d96 Compare August 5, 2024 16:51
@benpankow benpankow merged commit 07b5902 into master Aug 6, 2024
2 checks passed
@benpankow benpankow deleted the benpankow/adjust-mapping-docs branch August 6, 2024 00:27
benpankow added a commit that referenced this pull request Aug 7, 2024
…23385)

Adds .rst entry and link to apidoc for file path mapping objects, since
this is probably the most confusing part of mapping to source control.

Vercel preview.

---------

Co-authored-by: Erin Cochran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants