remove compute log manager UI #23422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 269d095. |
prha
force-pushed
the
prha/rm_graphql_compute_logs
branch
from
df9579c to
b8295b9
Compare
prha
force-pushed
the
prha/instance_assert
branch
from
69839c9 to
5804f3d
Compare
prha
force-pushed
the
prha/rm_graphql_compute_logs
branch
from
b8295b9 to
269d095
Compare
This was referenced Aug 5, 2024
hellendag
approved these changes
Aug 6, 2024
prha
added a commit
that referenced
this pull request
Aug 6, 2024
## Summary & Motivation We should always have a compute log manager implementing the `CapturedLogManager` interface, so we can get rid of all the UI code in the non-captured log manager branch. ## How I Tested These Changes BK, loaded run page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We should always have a compute log manager implementing the
CapturedLogManagerinterface, so we can get rid of all the UI code in the non-captured log manager branch.How I Tested These Changes
BK, loaded run page