Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] - Add Declarative Automation concept page (DOC-321) #23425

Merged
merged 12 commits into from
Aug 7, 2024

Conversation

erinkcochran87
Copy link
Contributor

@erinkcochran87 erinkcochran87 commented Aug 5, 2024

Summary & Motivation

This PR:

  • Adds a new concept page for Declarative Automation (DA)
  • Updates the Automation page with info about DA
  • Removes the AMP page
  • Updates links from AMP to the DA page
  • Adds a redirect from AMP to DA

TODO:

  • Add screenshots
  • Add customization guide + update links
  • Update sidenav
  • TBD: Remove AMP page + add redirect?

How I Tested These Changes

@graphite-app graphite-app bot added the area: docs Related to documentation in general label Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-jns328prl-elementl.vercel.app
https://erin-doc-321-dc-concept-page.dagster.dagster-docs.io

Direct link to changed pages:

@erinkcochran87
Copy link
Contributor Author

@OwenKephart Back to you. In this last round, I:

  • Added your suggestion (ty!)
  • Removed the AMP page, updated links, and added a redirect
  • Updated the sidenav
  • Updated mentions of AMP to DA in a few places - these could use eyes
  • Updated the Benefits section in the DA page to try to be more compelling

Copy link
Contributor

@OwenKephart OwenKephart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@erinkcochran87 erinkcochran87 merged commit db05469 into master Aug 7, 2024
1 of 2 checks passed
@erinkcochran87 erinkcochran87 deleted the erin/doc-321-dc-concept-page branch August 7, 2024 14:36
erinkcochran87 added a commit that referenced this pull request Aug 7, 2024
## Summary & Motivation

This PR adds a customization guide for automation conditions to the
docs.

TODOs

- [x] Add screenshots
- [x] Update sidenav
- [x] Add link to Declarative Automation concept page

The busted links in BK will resolve once #23425 is merged.

## How I Tested These Changes
jmsanders pushed a commit that referenced this pull request Aug 7, 2024
## Summary & Motivation

This PR:

- Adds a new concept page for Declarative Automation (DA)
- Updates the **Automation** page with info about DA
- Removes the AMP page
- Updates links from AMP to the DA page
- Adds a redirect from AMP to DA

TODO:

- [x] Add screenshots
- [ ] Add customization guide + update links
- [x] Update sidenav
- [x] TBD: Remove AMP page + add redirect?

## How I Tested These Changes

(cherry picked from commit db05469)
jmsanders pushed a commit that referenced this pull request Aug 7, 2024
## Summary & Motivation

This PR adds a customization guide for automation conditions to the
docs.

TODOs

- [x] Add screenshots
- [x] Update sidenav
- [x] Add link to Declarative Automation concept page

The busted links in BK will resolve once #23425 is merged.

## How I Tested These Changes

(cherry picked from commit 21f10ae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants