[ui] Upgrade Storybook #23445
Merged
[ui] Upgrade Storybook #23445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hellendag and the rest of your teammates on |
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 6eed7e0. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 6eed7e0. |
salazarm
approved these changes
Aug 6, 2024
bengotow
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
I just realized that my change to upgrade
ellipticwon't resolve the dependabot alerts. I misread the alert -- there is currently no version ofellipticthat resolves the issue, so I was just upgrading us to the latest (still broken) version.Our
ellipticusage is part of the dependencies of Storybook, so I figured maybe the latest Storybook version would have eliminated it. No such luck, but here's the Storybook upgrade anyway.How I Tested These Changes
yarn storybookinui-coreandui-components.