Bust RunTimeline cache #23482
Merged
Bust RunTimeline cache #23482
+101
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellendag
approved these changes
Aug 7, 2024
| id: localCacheIdPrefix ? `${localCacheIdPrefix}-useRunsForTimeline-filtered` : false, | ||
| keyPrefix: JSON.stringify(filter), | ||
| keyMaxCount: 3, | ||
| version: 1, |
There was a problem hiding this comment.
Track this value in a single module-level const (with a loud comment?) so that we don't miss changing it in both places?
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 23d8d18. |
jmsanders
pushed a commit
that referenced
this pull request
Aug 7, 2024
## Summary & Motivation 1. Add a version parameter to `HourlyDataCache` 2. If the version in the indexeddb cache doesn't match the version in code then don't use the indexeddb cache data at all 3. Add version parameter to useRunTImeline ## How I Tested These Changes Loaded the run timeline using app-proxy and saw that the cache was cleared. Subsequent loads used the cache (cherry picked from commit f134bc6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
HourlyDataCacheHow I Tested These Changes
Loaded the run timeline using app-proxy and saw that the cache was cleared. Subsequent loads used the cache