Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shared files for Cloud to override user settings / feature flags #23485

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Add shared files for Cloud to override user settings / feature flags #23485

merged 3 commits into from
Aug 8, 2024

Conversation

salazarm
Copy link
Contributor

@salazarm salazarm commented Aug 7, 2024

Summary & Motivation

  • Added FeatureFlags.oss.tsx
    • This will allow cloud to supply its own list of FeatureFlags
  • Renamed getVisibleFeatureFlagRows.tsx → .getVisibleFeatureFlagRows.oss
    • Similarly cloud will provide its own visible feature flag rows.

@salazarm salazarm requested review from bengotow and hellendag August 7, 2024 19:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-4xnalcouy-elementl.vercel.app
https://salazarm-feature-flag-injection.core-storybook.dagster-docs.io

Built with commit 8264798.
This pull request is being automatically deployed with vercel-action

@salazarm salazarm merged commit 5792a90 into master Aug 8, 2024
2 checks passed
@salazarm salazarm deleted the salazarm/feature-flag-injection branch August 8, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellendag hellendag hellendag approved these changes

@bengotow bengotow Awaiting requested review from bengotow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salazarm @hellendag