Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] [revamp] - Seed Concept pages #23602

Merged
merged 7 commits into from
Aug 13, 2024
Merged

[docs] [revamp] - Seed Concept pages #23602

merged 7 commits into from
Aug 13, 2024

Conversation

erinkcochran87
Copy link
Contributor

Summary & Motivation

How I Tested These Changes

@graphite-app graphite-app bot added the area: docs Related to documentation in general label Aug 12, 2024
@erinkcochran87 erinkcochran87 changed the base branch from master to docs/revamp August 12, 2024 23:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 12, 2024 •
edited
Loading

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-qe83xbfes-elementl.vercel.app
https://erin-seed-concept-pages.dagster.dagster-docs.io

Direct link to changed pages:

PedramNavid
PedramNavid reviewed Aug 12, 2024
View reviewed changes
docs/docs-next/docs/concepts/assets/asset-checks.md Outdated
@@ -0,0 +1,6 @@
---
title: "Asset checks"
sidebar_position: 7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually do these in increments of 10. That way when you decide you want to add something between 7 and 8, you don't have to go and change everything above and below but you just add one called 71.

PedramNavid
PedramNavid reviewed Aug 12, 2024
View reviewed changes
docs/docs-next/docs/tutorial/quick-start.md Outdated
# Quickstart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to delete this one

PedramNavid
PedramNavid reviewed Aug 12, 2024
View reviewed changes
Copy link
Contributor

@PedramNavid PedramNavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few comments

@netlify Netlify
Copy link

netlify bot commented Aug 13, 2024 •
edited
Loading

✅ Deploy Preview for dagsterapidocs canceled.

Name Link
🔨 Latest commit cf504f9
🔍 Latest deploy log https://app.netlify.com/sites/dagsterapidocs/deploys/66bb92822c5bdc0008514d79

@PedramNavid PedramNavid force-pushed the erin/seed-concept-pages branch 2 times, most recently from 4e4dff3 to 13d4b5d Compare August 13, 2024 16:53
@PedramNavid PedramNavid force-pushed the erin/seed-concept-pages branch from 13d4b5d to cf504f9 Compare August 13, 2024 17:06
@github-actions GitHub Actions
Copy link

Deploy preview for dagster-docs-next ready!

✅ Preview
https://dagster-docs-next-2se403qzx-elementl.vercel.app
https://dagster-docs-next.dagster.dagster-docs.io

Built with commit cf504f9.
This pull request is being automatically deployed with vercel-action

@PedramNavid PedramNavid merged commit aa7cac7 into docs/revamp Aug 13, 2024
7 of 8 checks passed
@PedramNavid PedramNavid deleted the erin/seed-concept-pages branch August 13, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PedramNavid PedramNavid PedramNavid left review comments

Assignees
No one assigned
Labels
area: docs Related to documentation in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erinkcochran87 @PedramNavid