[DA] Add doc block to AutomationCondition, mark static constructors public #23649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @OwenKephart and the rest of your teammates on |
OwenKephart
force-pushed
the
08-14-_DA_Add_doc_block_to_AutomationCondition_mark_static_constructors_public
branch
from
e27a839 to
4bff5c3
Compare
schrockn
reviewed
Aug 16, 2024
python_modules/dagster/dagster/_core/definitions/declarative_automation/automation_condition.py
Outdated
Show resolved
Hide resolved
schrockn
reviewed
Aug 16, 2024
python_modules/dagster/dagster/_core/definitions/declarative_automation/automation_condition.py
Outdated
Show resolved
Hide resolved
schrockn
reviewed
Aug 16, 2024
python_modules/dagster/dagster/_core/definitions/declarative_automation/automation_condition.py
Outdated
Show resolved
Hide resolved
OwenKephart
force-pushed
the
08-14-_DA_Add_doc_block_to_AutomationCondition_mark_static_constructors_public
branch
from
4bff5c3 to
db0e2cf
Compare
OwenKephart
force-pushed
the
08-14-_DA_Add_doc_block_to_AutomationCondition_mark_static_constructors_public
branch
from
db0e2cf to
3b8a2ea
Compare
sryza
approved these changes
Aug 21, 2024
OwenKephart
dismissed
schrockn’s stale review
Responded to comments, just want to get this out for this week's release -- can update language if necessary afterwards
OwenKephart
deleted the
08-14-_DA_Add_doc_block_to_AutomationCondition_mark_static_constructors_public
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This allows information about this class to show up in our API docs
How I Tested These Changes