Update backfills docs with more up to date info on single runs #23724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @Rhiyo is this PR still a work-in-progress that you will be adding more changes to? |
|
I was going to leave it as this but I think there is a lot more useful information that could be added and better code examples. I'll attempt to rewrite more. |
graphite-app
bot
requested review from
PedramNavid,
cmpadden and
C00ldudeNoonan
Graphite Automations"Label and add CE on all Docs" took an action on this PR • (09/28/24)3 reviewers were added to this PR based on Pedram Navid's automation. |
|
hi @Rhiyo just wanted to check in on this? |
cmpadden
requested review from
neverett
and removed request for
erinkcochran87
cmpadden
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
I noticed the docs of the backfill page for single runs are out of date with 1.8 based on the changes here: #21259
Starting this PR to correct that - the note on the backfill was incorrent in its current form.
It seems if you do try and run a job with multiple different backfill polices it will default to the policy with least max_partitions_per_run, failing that it will default to using multi_run(max_partitions_per_run=1)