Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add even more kind tag icons #23746

Merged
merged 7 commits into from
Aug 21, 2024
Merged

Add even more kind tag icons #23746

merged 7 commits into from
Aug 21, 2024

Conversation

braunjj
Copy link
Contributor

@braunjj braunjj commented Aug 20, 2024

Summary & Motivation

Revamps the entire set of Kind tags. Adds popular languages, databases, data sources, ai tools, and other data/dev tools.
image

How I Tested These Changes

loading up the web ui

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 20, 2024 •
edited
Loading

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-7xy7n84cn-elementl.vercel.app
https://jb-revamp-compute-kinds.core-storybook.dagster-docs.io

Built with commit c745825.
This pull request is being automatically deployed with vercel-action

@graphite-app graphite-app bot added the area: docs Related to documentation in general label Aug 20, 2024
@graphite-app graphite-app bot requested a review from erinkcochran87 August 20, 2024 22:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 20, 2024 •
edited
Loading

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-ph34vnpja-elementl.vercel.app
https://jb-revamp-compute-kinds.dagster.dagster-docs.io

Direct link to changed pages:

@erinkcochran87 erinkcochran87 removed their request for review August 21, 2024 01:12
bengotow
bengotow approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@bengotow bengotow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great! It looks like the build will probably pass if you rebase on master, there was some sort of unrelated issue on the python side.

@braunjj braunjj merged commit fa08456 into master Aug 21, 2024
3 of 4 checks passed
@braunjj braunjj deleted the jb-revamp-compute-kinds branch August 21, 2024 15:17
cmpadden pushed a commit that referenced this pull request Aug 21, 2024
@braunjj @cmpadden
Add even more kind tag icons (#23746)
6097017 
## Summary & Motivation
Revamps the entire set of Kind tags. Adds popular languages, databases,
data sources, ai tools, and other data/dev tools.

![image](https://github.com/user-attachments/assets/f317a0a3-3c55-41c2-b423-e347ca80b2f6)


## How I Tested These Changes
loading up the web ui
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellendag hellendag hellendag approved these changes

@bengotow bengotow bengotow approved these changes

@salazarm salazarm Awaiting requested review from salazarm

Assignees
No one assigned
Labels
area: docs Related to documentation in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@braunjj @bengotow @hellendag