Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-beta] Merge the new beta Docs site #23748

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Conversation

PedramNavid
Copy link
Contributor

Summary & Motivation

This adds the new beta docs site into our main repo. This is still a work-in-progress, and does not affect our existing docs deployment. This work was originally undertook in the #23530 branch, however, I have brought it in as a squashed self-contained PR to keep the history clean.

How I Tested These Changes

Built locally, BK, and Vercel.

This adds some base linting styles using Vale. These are a collection of
both suggestions and errors that will raise when run against our new
docs site.
This is a single commit for the work done on the new docs revamp
project. In order to keep the commit history clean, changes from the
docs/revamp branch were squashed into a single commit.
@PedramNavid PedramNavid requested a review from yuhan August 20, 2024 04:15
@graphite-app graphite-app bot added the area: docs Related to documentation in general label Aug 20, 2024
@graphite-app graphite-app bot requested a review from erinkcochran87 August 20, 2024 04:15
Copy link

github-actions bot commented Aug 20, 2024

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-quiw1luwy-elementl.vercel.app
https://docs-revamp-merge.dagster.dagster-docs.io

Direct link to changed pages:

Copy link
Contributor

@cmpadden cmpadden Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove along with other docusaurus images

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call

Copy link

Deploy preview for dagster-docs-beta ready!

✅ Preview
https://dagster-docs-beta-3dsypvwoo-elementl.vercel.app

Built with commit 98fb6f3.
This pull request is being automatically deployed with vercel-action

@PedramNavid PedramNavid merged commit 78ea485 into master Aug 20, 2024
3 of 4 checks passed
@PedramNavid PedramNavid deleted the docs/revamp-merge branch August 20, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants