simplify prepare_if_dev explanation in dbt tutorial
#23765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-m192zzgqc-elementl.vercel.app Direct link to changed pages: |
|
@maximearmstrong @erinkcochran87 - mind taking a look at this one? |
|
|
||
| In this tutorial, we're going with the first option: We run `dagster dev` and use `dbt_project.prepare_if_dev()` to prepare the dbt project and create the manifest. | ||
| However, in development, when you're iteratively making changes to files inside your dbt project and seeing what effects they have, you typically want those changes to be reflected in your local Dagster UI ASAP, without requiring you to explicitly re-generate the manifest. `dbt_project.prepare_if_dev()` helps with this – it re-generates your `manifest.json` at the time Dagster imports your code, _but_ only if it's being imported by the `dagster dev` command. |
There was a problem hiding this comment.
Suggested change
| However, in development, when you're iteratively making changes to files inside your dbt project and seeing what effects they have, you typically want those changes to be reflected in your local Dagster UI ASAP, without requiring you to explicitly re-generate the manifest. `dbt_project.prepare_if_dev()` helps with this – it re-generates your `manifest.json` at the time Dagster imports your code, _but_ only if it's being imported by the `dagster dev` command. | |
| However, in development, you typically want changes made to files in your dbt project to be immediately reflected in the Dagster UI without needing to regenerate the manifest. | |
| `dbt_project.prepare_if_dev()` helps with this – it re-generates your `manifest.json` at the time Dagster imports your code, but only if it's being imported by the `dagster dev` command. |
I think we can tighten this up more
There was a problem hiding this comment.
👍 good point, made this change
sryza
force-pushed
the
dbt-tutorial-manifest
branch
from
0707b4b to
b03ce04
Compare
erinkcochran87
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The dbt tutorial explains
prepare_if_devin a couple different ways, and I think it could get the same info across with a bit less.How I Tested These Changes