[ui] Fix “filter to group” action no longer working in the asset graph #23768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salazarm
reviewed
Aug 20, 2024
| @@ -74,8 +74,6 @@ type Props = { | |||
| options: GraphExplorerOptions; | |||
| setOptions?: (options: GraphExplorerOptions) => void; | |||
|
|
|||
| assetFilterState?: AssetFilterState; | |||
There was a problem hiding this comment.
oh could we just make this non optional? I think the prop not being passed in is probably a bug
There was a problem hiding this comment.
Discussed in Slack, it looks like the only scoping that happens above this component is passed in via fetchOptions={{pipelineSelector}}(on job pages) and all the other filter state is now within the AssetGraphExplorer, so it's ok to rm this!
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit da173f0. |
salazarm
approved these changes
Aug 20, 2024
bengotow
force-pushed
the
bengotow-2024-08/FE-521
branch
from
1c77312 to
62a54ac
Compare
bengotow
force-pushed
the
bengotow-2024-08/FE-521
branch
from
62a54ac to
da173f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
https://linear.app/dagster-labs/issue/FE-521/[bug]-filter-to-group-action-no-longer-works-in-the-lineage-ui
The AssetGraphExplorer had an optional
assetFilterState?: AssetFilterStatethat needed to be passed for this filtering to work, and it's no longer passed anywhere the component is used. I updated this to work the same way the clickable computeKind tags work.How I Tested These Changes
I verified that the asset graph sidebar and asset graph collapsed + expanded nodes "Filter to group" options all still work