switch tick filters to contained set rather than every permutation #23781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit e2f652d. |
salazarm
reviewed
Aug 21, 2024
Comment on lines
63
to
65
| ALL = 'ALL', | ||
| FAILED = 'FAILED', | ||
| SUCCESS = 'SUCCESS', |
There was a problem hiding this comment.
you could do just
Suggested change
| ALL = 'ALL', | |
| FAILED = 'FAILED', | |
| SUCCESS = 'SUCCESS', | |
| ALL, | |
| FAILED, | |
| SUCCESS, |
salazarm
approved these changes
Aug 21, 2024
prha
force-pushed
the
prha/job_tick_filter
branch
from
062d295 to
e2f652d
Compare
prha
added a commit
that referenced
this pull request
Aug 29, 2024
…23781) ## Summary & Motivation We want to set up a constrained set of indices to make the tick query faster. We can do that more efficiently for common queries if we restrict the views enabled in the UI. I think the common modes are going to be `All ticks`, `Failed`, and `Requested`. I don't think it's very useful to see `Started` or `Skipped` ticks in isolation. https://github.com/user-attachments/assets/fa2df72b-ad8f-43ae-9b16-640b53bdabcd ## How I Tested These Changes BK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We want to set up a constrained set of indices to make the tick query faster. We can do that more efficiently for common queries if we restrict the views enabled in the UI.
I think the common modes are going to be
All ticks,Failed, andRequested.I don't think it's very useful to see
StartedorSkippedticks in isolation.Screen.Recording.2024-08-20.at.5.39.58.PM.mov
How I Tested These Changes
BK