[docs-beta] README change regarding lint:fix #23858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hellendag and the rest of your teammates on |
|
Deploy preview for dagster-docs-beta ready! ✅ Preview Built with commit 4d49b80. |
hellendag
force-pushed
the
dish/doc-328-revamp-testing-completed-tasks
branch
from
ff96069 to
875c116
Compare
hellendag
force-pushed
the
dish/doc-328-revamp-testing-completed-tasks
branch
from
875c116 to
4d49b80
Compare
PedramNavid
reviewed
Aug 23, 2024
| @@ -63,15 +63,12 @@ This command starts a local development server and opens up a browser window. Mo | |||
| To check the documentation for different issues, use the following: | |||
|
|
|||
| ```bash | |||
| ## Lints Markdown content using prettier | |||
| ## Lints all content, applies lint autofixes and prettier changes | |||
| yarn lint | |||
There was a problem hiding this comment.
i think this breaks our CI right? since we have a GH action that ran prettier --check and eslint without fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Modified yarn commands. Now:
tsruns TypeScriptlintapplies prettier changes and autofixesvalechecks valuelint-and-valeis a combination of the two aboveHow I Tested These Changes
Run the commands, verify that they behave as expected.
Changelog [New | Bug | Docs]
NOCHANGELOG