[docathon] pass tox for asset factories #23909
Conversation
Graphite Automations"docs-beta - Assign Reviewers" took an action on this PR • (08/26/24)2 reviewers were added to this PR based on Pedram Navid's automation. |
|
Deploy preview for dagster-docs-beta ready! ✅ Preview Built with commit 3234f3d. |
...ppets/docs_beta_snippets/guides/data-modeling/asset-factories/advanced-yaml-asset-factory.py
Outdated
Show resolved
Hide resolved
...nippets/docs_beta_snippets/guides/data-modeling/asset-factories/simple-yaml-asset-factory.py
Outdated
Show resolved
Hide resolved
...eta_snippets/docs_beta_snippets/guides/data-modeling/asset-factories/python-asset-factory.py
Show resolved
Hide resolved
| @@ -14,7 +14,7 @@ | |||
| "Operating System :: OS Independent", | |||
| ], | |||
| packages=find_packages(exclude=["test"]), | |||
| install_requires=["dagster-cloud"], | |||
| install_requires=[], | |||
There was a problem hiding this comment.
wonder if tox.ini can point at another git repo so we can target latest master
There was a problem hiding this comment.
I do think it's possible, but complicated slightly because it's in a private repo.
| @@ -33,5 +37,5 @@ def load_etl_jobs_from_yaml(yaml_path: str) -> dg.Definitions: | |||
| return dg.Definitions.merge(*defs) | |||
|
|
|||
|
|
|||
| defs = load_etl_jobs_from_yaml("etl_jobs.yaml") | |||
| defs = load_etl_jobs_from_yaml(str(Path(__file__).parent / "etl_jobs.yaml")) | |||
There was a problem hiding this comment.
hoping we can get rid of this in all the examples and replace it with a chdir in the test case so the code samples are simpler
There was a problem hiding this comment.
I think this is a decent compromise, what do you think?
defs = load_etl_jobs_from_yaml(
"docs_beta_snippets/guides/data-modeling/asset-factories/etl_jobs.yaml"
)
There was a problem hiding this comment.
still think it's pretty noisy to have as a code sample in the guides
Summary & Motivation
dagster-cloudHow I Tested These Changes
toxChangelog [New | Bug | Docs]
NOCHANGELOG