-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docathon] Clean up metadata docs (DOC-382) #23915
Conversation
Deploy preview for dagster-docs-beta ready! ✅ Preview Built with commit efca868. |
02b793c
to
60fe0dc
Compare
Graphite Automations"docs-beta - Assign Reviewers" took an action on this PR • (08/26/24)3 reviewers were added to this PR based on Pedram Navid's automation. |
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-gi5vzeri7-elementl.vercel.app Direct link to changed pages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I left a few comments about things that aren't explicitly on this PR, as I didn't get a chance to review your original guide. Let me know if you'd prefer I handle anything as a follow up.
@erinkcochran87 I think I made all the changes requested |
Looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simply beautiful
Summary & Motivation
I learned some new things during @erinkcochran87's presentation
How I Tested These Changes
Changelog [New | Bug | Docs]
NOCHANGELOG