Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docathon] Clean up metadata docs (DOC-382) #23915

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Conversation

petehunt
Copy link
Contributor

Summary & Motivation

I learned some new things during @erinkcochran87's presentation

How I Tested These Changes

Changelog [New | Bug | Docs]

NOCHANGELOG

@petehunt petehunt changed the title Clean up metadata docs [docathon] Clean up metadata docs Aug 26, 2024
@graphite-app graphite-app bot requested a review from cmpadden August 26, 2024 16:47
@graphite-app graphite-app bot added the area: docs Related to documentation in general label Aug 26, 2024
Copy link

github-actions bot commented Aug 26, 2024

Deploy preview for dagster-docs-beta ready!

✅ Preview
https://dagster-docs-beta-mls7kngdf-elementl.vercel.app
https://petehunt-metadata-cleanup.dagster.dagster-docs.io

Built with commit efca868.
This pull request is being automatically deployed with vercel-action

@petehunt petehunt force-pushed the petehunt/metadata-cleanup branch from 02b793c to 60fe0dc Compare August 26, 2024 16:49
Copy link

graphite-app bot commented Aug 26, 2024

Graphite Automations

"docs-beta - Assign Reviewers" took an action on this PR • (08/26/24)

3 reviewers were added to this PR based on Pedram Navid's automation.

Copy link

github-actions bot commented Aug 26, 2024

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-gi5vzeri7-elementl.vercel.app
https://petehunt-metadata-cleanup.dagster.dagster-docs.io

Direct link to changed pages:

Copy link
Contributor

@erinkcochran87 erinkcochran87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I left a few comments about things that aren't explicitly on this PR, as I didn't get a chance to review your original guide. Let me know if you'd prefer I handle anything as a follow up.

docs/docs-beta/docs/guides/data-modeling/metadata.md Outdated Show resolved Hide resolved
docs/docs-beta/docs/guides/data-modeling/metadata.md Outdated Show resolved Hide resolved
docs/docs-beta/docs/guides/data-modeling/metadata.md Outdated Show resolved Hide resolved
docs/docs-beta/docs/guides/data-modeling/metadata.md Outdated Show resolved Hide resolved
docs/docs-beta/docs/guides/data-modeling/metadata.md Outdated Show resolved Hide resolved
@petehunt
Copy link
Contributor Author

@erinkcochran87 I think I made all the changes requested

@erinkcochran87 erinkcochran87 changed the title [docathon] Clean up metadata docs [docathon] Clean up metadata docs (DOC-382) Aug 26, 2024
@erinkcochran87
Copy link
Contributor

Looks good to me!

Copy link
Contributor

@PedramNavid PedramNavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simply beautiful

@petehunt petehunt merged commit 03f8cd0 into master Aug 27, 2024
3 of 4 checks passed
@petehunt petehunt deleted the petehunt/metadata-cleanup branch August 27, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general docathon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants