Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC-366] Add Dagster Plus audit log guide #23931

Merged
merged 11 commits into from
Aug 29, 2024

Conversation

benpankow
Copy link
Member

@benpankow benpankow commented Aug 26, 2024

Summary & Motivation

Introduces a basic docs guide for the Plus audit log, including a list of auditable actions.
https://dagster-docs-beta-j3dho3hl2-elementl.vercel.app/dagster-plus/access/rbac/audit-logs

Changelog [Docs]

NOCHANGELOG

@graphite-app graphite-app bot added the area: docs Related to documentation in general label Aug 26, 2024
@benpankow
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benpankow and the rest of your teammates on Graphite Graphite

Copy link

graphite-app bot commented Aug 26, 2024

Graphite Automations

"docs-beta - Assign Reviewers" took an action on this PR • (08/26/24)

3 reviewers were added to this PR based on Pedram Navid's automation.

Copy link

github-actions bot commented Aug 26, 2024

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-muof7k6a9-elementl.vercel.app
https://ben-doc-366-write-dagster-audit-logs.dagster.dagster-docs.io

Direct link to changed pages:

@benpankow benpankow requested a review from gibsondan August 26, 2024 22:16
Copy link

github-actions bot commented Aug 26, 2024

Deploy preview for dagster-docs-beta ready!

Preview available at https://dagster-docs-beta-6clgbybzd-elementl.vercel.app

Direct link to changed pages:

Copy link
Contributor

@PedramNavid PedramNavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will let @erinkcochran87 review as well, but can you export the Audit Log at all? That's what i imagine i would want to do with this.

@benpankow
Copy link
Member Author

Will let @erinkcochran87 review as well, but can you export the Audit Log at all? That's what i imagine i would want to do with this.

Good call - you can over GQL, per #22361. Added a brief section covering this. Do we have a new page about the GQL API or Python client? might be good to link to that if so, but couldn't find one

@@ -0,0 +1,17 @@
query AuditLogQuery(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the interest of a "complete" example, I think it would be helpful to link or describe either how you would access the /graphql endpoint, or like how you would do it in python.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Added a brief sentence, can link out to the graphql page once that's ready.

@erinkcochran87
Copy link
Contributor

Do we have a new page about the GQL API or Python client? might be good to link to that if so, but couldn't find one

@benpankow We will, likely in the References section in the top nav. Location is tbd, but it'll be in there somewhere.

Copy link
Contributor

@cnolanminich cnolanminich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added one question around keeping the list of audit log events up to date but otherwise lgtm

## Audit log entry types

| Event type | Description | Additional details |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this table -- how often do we add audit log events and is there a risk it will become stale?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OwenKephart's auto-generating alert doc makes me want to give similar treatment to everything like this. Could look into adapting it.

Copy link
Member Author

@benpankow benpankow Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great question. I would expect we would add new events somewhat often (every few months). Took a stab at making a parity unit test here which would give us some notification if the tables got out of sync: https://github.com/dagster-io/internal/pull/11224

Not sure if in practice this is more annoying than it's worth

@benpankow benpankow merged commit 756000b into master Aug 29, 2024
2 of 3 checks passed
@benpankow benpankow deleted the ben/doc-366-write-dagster-audit-logs branch August 29, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general docathon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants