-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC-366] Add Dagster Plus audit log guide #23931
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @benpankow and the rest of your teammates on Graphite |
Graphite Automations"docs-beta - Assign Reviewers" took an action on this PR • (08/26/24)3 reviewers were added to this PR based on Pedram Navid's automation. |
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-muof7k6a9-elementl.vercel.app Direct link to changed pages: |
Deploy preview for dagster-docs-beta ready! Preview available at https://dagster-docs-beta-6clgbybzd-elementl.vercel.app Direct link to changed pages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will let @erinkcochran87 review as well, but can you export the Audit Log at all? That's what i imagine i would want to do with this.
Good call - you can over GQL, per #22361. Added a brief section covering this. Do we have a new page about the GQL API or Python client? might be good to link to that if so, but couldn't find one |
@@ -0,0 +1,17 @@ | |||
query AuditLogQuery( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the interest of a "complete" example, I think it would be helpful to link or describe either how you would access the /graphql
endpoint, or like how you would do it in python.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. Added a brief sentence, can link out to the graphql page once that's ready.
@benpankow We will, likely in the References section in the top nav. Location is tbd, but it'll be in there somewhere. |
Co-authored-by: Erin Cochran <[email protected]>
Co-authored-by: Erin Cochran <[email protected]>
Co-authored-by: Erin Cochran <[email protected]>
Co-authored-by: Erin Cochran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added one question around keeping the list of audit log events up to date but otherwise lgtm
## Audit log entry types | ||
|
||
| Event type | Description | Additional details | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this table -- how often do we add audit log events and is there a risk it will become stale?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OwenKephart's auto-generating alert doc makes me want to give similar treatment to everything like this. Could look into adapting it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great question. I would expect we would add new events somewhat often (every few months). Took a stab at making a parity unit test here which would give us some notification if the tables got out of sync: https://github.com/dagster-io/internal/pull/11224
Not sure if in practice this is more annoying than it's worth
Summary & Motivation
Introduces a basic docs guide for the Plus audit log, including a list of auditable actions.
https://dagster-docs-beta-j3dho3hl2-elementl.vercel.app/dagster-plus/access/rbac/audit-logs
Changelog [Docs]
NOCHANGELOG