[dagster-aws] ignore pyright errors with boto3-stubs #23954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 27, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @danielgafni and the rest of your teammates on |
danielgafni
force-pushed
the
08-27-_dagster-aws_ignore_pyright_errors_with_boto3-stubs
branch
2 times, most recently
from
3e312a4 to
cba2bfc
Compare
|
|
danielgafni
force-pushed
the
08-09-_dagster-aws_add_ecs_pipes
branch
from
7f389db to
eac4e63
Compare
danielgafni
force-pushed
the
08-27-_dagster-aws_ignore_pyright_errors_with_boto3-stubs
branch
3 times, most recently
from
ebf9569 to
469c63a
Compare
2 tasks
|
Can you give some more context on these type errors, why the code is working now, and what the likely fix is? Is there a pattern here? |
|
Most of them are because of accessing keys in boto3 response dicts. |
|
Ok. It would be great if in a follow up you could fix the trivial ones (even if it is just doing check.not_none(response.get("Whatever"))
…On Wed, Aug 28, 2024 at 8:43 AM, Daniel Gafni < ***@***.*** > wrote:
Most of them are because of accessing keys in boto3 response dicts.
For some reason most of them are flagged as NonRequired , so accessing with
[] instead of.get() raises a pyright error now.
I think it's fine to ignore these errors since this code actually never
raised runtime errors (so in practice these keys are always set).
—
Reply to this email directly, view it on GitHub (
#23954 (comment) )
, or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AG3IK6JMYM7JI4ENDNHVXETZTXV2ZAVCNFSM6AAAAABNF2OK2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJVG4YDONJVGQ
).
You are receiving this because your review was requested. Message ID: <dagster-io/dagster/pull/23954/c2315707554
@ github. com>
|
danielgafni
force-pushed
the
08-09-_dagster-aws_add_ecs_pipes
branch
from
eac4e63 to
ffc36c4
Compare
danielgafni
force-pushed
the
08-27-_dagster-aws_ignore_pyright_errors_with_boto3-stubs
branch
from
469c63a to
5ce998f
Compare
|
I wonder why |
danielgafni
merged commit a0f68ca
into
08-09-_dagster-aws_add_ecs_pipes
1 check was pending
danielgafni
deleted the
08-27-_dagster-aws_ignore_pyright_errors_with_boto3-stubs
branch
danielgafni
added a commit
that referenced
this pull request
Aug 28, 2024
## Summary & Motivation Ignore pyright errors in `dagster-aws` which popped out after the introduction of `boto3-stubs-lite`. I suggest we slowly remove these ignore comments and fix the code for pyright to pass over time. I made a script to do it automatically. ## How I Tested These Changes pyright should be passing now ## Changelog [New | Bug | Docs] > NOCHANGELOG
danielgafni
added a commit
that referenced
this pull request
Aug 28, 2024
## Summary & Motivation Ignore pyright errors in `dagster-aws` which popped out after the introduction of `boto3-stubs-lite`. I suggest we slowly remove these ignore comments and fix the code for pyright to pass over time. I made a script to do it automatically. ## How I Tested These Changes pyright should be passing now ## Changelog [New | Bug | Docs] > NOCHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Ignore pyright errors in
dagster-awswhich popped out after the introduction ofboto3-stubs-lite.I suggest we slowly remove these ignore comments and fix the code for pyright to pass over time.
I made a script to do it automatically.
How I Tested These Changes
pyright should be passing now
Changelog [New | Bug | Docs]