Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-beta] tweaks to configuring assets page #23969

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

sryza
Copy link
Contributor

@sryza sryza commented Aug 27, 2024

Summary & Motivation

This is a quick followup to this PR on asset configuration.

I wanted to make it super clear that the point of asset config is runtime configuration, because this has been a source of confusion in the past which makes it more difficult to explain asset factories.

Also incorporated @erinkcochran87's feedback here: #23924 (comment).

How I Tested These Changes

Changelog [New | Bug | Docs]

NOCHANGELOG

@sryza sryza force-pushed the asset-config-tweaks branch from c0520db to 82da205 Compare August 27, 2024 16:57
@graphite-app graphite-app bot added the area: docs Related to documentation in general label Aug 27, 2024
@graphite-app graphite-app bot requested review from cmpadden and PedramNavid August 27, 2024 16:58
Copy link

graphite-app bot commented Aug 27, 2024

Graphite Automations

"docs-beta - Assign Reviewers" took an action on this PR • (08/27/24)

2 reviewers were added to this PR based on Pedram Navid's automation.

Copy link

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-11zixs6hk-elementl.vercel.app
https://asset-config-tweaks.dagster.dagster-docs.io

Direct link to changed pages:

Copy link

Deploy preview for dagster-docs-beta ready!

✅ Preview
https://dagster-docs-beta-8zr0e5le7-elementl.vercel.app
https://asset-config-tweaks.dagster.dagster-docs.io

Built with commit 82da205.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

@cmpadden cmpadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Sandy.

@cmpadden cmpadden merged commit 850224f into master Aug 27, 2024
4 checks passed
@cmpadden cmpadden deleted the asset-config-tweaks branch August 27, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants