make job_name param on PartitionArgs and PartitionNames args optional
#23983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sryza
force-pushed
the
partition-grpcs-get-job-name
branch
from
6c6e1ce to
1e9102f
Compare
sryza
force-pushed
the
partition-args-job-name-optional
branch
from
5f1de9b to
0364c50
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 5f1de9b. |
gibsondan
approved these changes
Aug 27, 2024
sryza
added a commit
that referenced
this pull request
Aug 27, 2024
…tional (#23983) Having `job_name` as a required param causes problems when a pre-1.8.2 agent is used, because the agent strips the parameter off when reserializing the object. Added unit tests. Verified that these tests pass when cherry-picking onto the 1.8.2 branch. Fixes a bug that caused an error when loading the launchpad for a partition, when using in Dagster+ with an agent with version below 1.8.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Having
job_nameas a required param causes problems when a pre-1.8.2 agent is used, because the agent strips the parameter off when reserializing the object.How I Tested These Changes
Added unit tests. Verified that these tests pass when cherry-picking onto the 1.8.2 branch.
Changelog [Bug˝]
Fixes a bug that caused an error when loading the launchpad for a partition, when using in Dagster+ with an agent with version below 1.8.2.