Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4/k][ui] Hide kind tags by default from asset view #24295

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

benpankow
Copy link
Member

@benpankow benpankow commented Sep 6, 2024

Summary

Adds a new collapsible "system tags" section to the tags pane in the asset sidebar. This is used currently solely for kind tags, which are hidden by default.
Screenshot 2024-09-06 at 11 26 05 AM
Screenshot 2024-09-06 at 11 25 58 AM

Test Plan

Tested locally.

Copy link

github-actions bot commented Sep 6, 2024

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-fageq42qv-elementl.vercel.app
https://benpankow-kinds-ui-4.core-storybook.dagster-docs.io

Built with commit ea1eead.
This pull request is being automatically deployed with vercel-action

@benpankow benpankow requested a review from sryza September 6, 2024 18:50
@benpankow benpankow force-pushed the benpankow/kinds-ui-3 branch from 857f297 to dde8987 Compare September 6, 2024 22:38
@benpankow benpankow force-pushed the benpankow/kinds-ui-4 branch from e06ac36 to 9ae48c6 Compare September 6, 2024 22:38
@benpankow
Copy link
Member Author

benpankow commented Sep 9, 2024

Merge activity

  • Sep 9, 9:36 AM PDT: @benpankow started a stack merge that includes this pull request via Graphite.
  • Sep 9, 9:41 AM PDT: Graphite rebased this pull request as part of a merge.
  • Sep 9, 9:42 AM PDT: @benpankow merged this pull request with Graphite.

@benpankow benpankow changed the base branch from benpankow/kinds-ui-3 to graphite-base/24295 September 9, 2024 16:37
@benpankow benpankow changed the base branch from graphite-base/24295 to master September 9, 2024 16:38
@benpankow benpankow force-pushed the benpankow/kinds-ui-4 branch from 21de5cc to ea1eead Compare September 9, 2024 16:40
@benpankow benpankow merged commit bb6fe9b into master Sep 9, 2024
1 of 2 checks passed
@benpankow benpankow deleted the benpankow/kinds-ui-4 branch September 9, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants