-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] delete backfills via daemon #25230
[wip] delete backfills via daemon #25230
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @jamiedemaria and the rest of your teammates on Graphite |
a5fdf03
to
253761c
Compare
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 253761c. |
@gibsondan can i get a quick pass on this to make sure it's heading in the general correct direction? |
a0ba58c
to
bd7dbfc
Compare
253761c
to
dbea56c
Compare
@@ -36,6 +36,7 @@ class BulkActionStatus(Enum): | |||
CANCELED = "CANCELED" | |||
COMPLETED_SUCCESS = "COMPLETED_SUCCESS" | |||
COMPLETED_FAILED = "COMPLETED_FAILED" # denotes that the backfill daemon completed successfully, but some runs failed | |||
DELETING = "DELETING" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: need to figure out how this status will be displayed in the UI since we convert backfill statuses to corresponding run statuses but there is no run status that aligns perfectly
bd7dbfc
to
5f35ff8
Compare
dbea56c
to
1c67547
Compare
5f35ff8
to
0d4ead6
Compare
1c67547
to
340744c
Compare
0d4ead6
to
b69d197
Compare
340744c
to
542a032
Compare
Summary & Motivation
Adds a new
DELETING
status for backfills. adds a condition to the backfill daemon so it can delete all runs associated with a backfill, then delete the backfill for backfills with the DELETING statusdagster/python_modules/dagster/dagster/_core/execution/asset_backfill.py
Line 802 in 75d9d72
How I Tested These Changes
new unit test
Changelog