Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] delete backfills via daemon #25230

Conversation

jamiedemaria
Copy link
Contributor

@jamiedemaria jamiedemaria commented Oct 11, 2024

Summary & Motivation

Adds a new DELETING status for backfills. adds a condition to the backfill daemon so it can delete all runs associated with a backfill, then delete the backfill for backfills with the DELETING status

How I Tested These Changes

new unit test

Changelog

Insert changelog entry or delete this section.

Copy link
Contributor Author

jamiedemaria commented Oct 11, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jamiedemaria and the rest of your teammates on Graphite Graphite

@jamiedemaria jamiedemaria force-pushed the jamie/backfill-delete-via-daemon branch from a5fdf03 to 253761c Compare October 14, 2024 16:51
@jamiedemaria jamiedemaria changed the base branch from master to jamie/storage-delete-backfill October 14, 2024 16:51
Copy link

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-8kdt9qs38-elementl.vercel.app
https://jamie-backfill-delete-via-daemon.core-storybook.dagster-docs.io

Built with commit 253761c.
This pull request is being automatically deployed with vercel-action

@jamiedemaria jamiedemaria marked this pull request as ready for review October 14, 2024 19:55
@jamiedemaria
Copy link
Contributor Author

@gibsondan can i get a quick pass on this to make sure it's heading in the general correct direction?

@jamiedemaria jamiedemaria force-pushed the jamie/storage-delete-backfill branch from a0ba58c to bd7dbfc Compare October 14, 2024 20:12
@jamiedemaria jamiedemaria force-pushed the jamie/backfill-delete-via-daemon branch from 253761c to dbea56c Compare October 14, 2024 20:12
@@ -36,6 +36,7 @@ class BulkActionStatus(Enum):
CANCELED = "CANCELED"
COMPLETED_SUCCESS = "COMPLETED_SUCCESS"
COMPLETED_FAILED = "COMPLETED_FAILED" # denotes that the backfill daemon completed successfully, but some runs failed
DELETING = "DELETING"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: need to figure out how this status will be displayed in the UI since we convert backfill statuses to corresponding run statuses but there is no run status that aligns perfectly

@jamiedemaria jamiedemaria force-pushed the jamie/storage-delete-backfill branch from bd7dbfc to 5f35ff8 Compare October 14, 2024 20:53
@jamiedemaria jamiedemaria force-pushed the jamie/backfill-delete-via-daemon branch from dbea56c to 1c67547 Compare October 14, 2024 20:53
@jamiedemaria jamiedemaria force-pushed the jamie/storage-delete-backfill branch from 5f35ff8 to 0d4ead6 Compare October 15, 2024 13:15
@jamiedemaria jamiedemaria force-pushed the jamie/backfill-delete-via-daemon branch from 1c67547 to 340744c Compare October 15, 2024 13:15
@jamiedemaria jamiedemaria force-pushed the jamie/storage-delete-backfill branch from 0d4ead6 to b69d197 Compare October 15, 2024 13:45
@jamiedemaria jamiedemaria force-pushed the jamie/backfill-delete-via-daemon branch from 340744c to 542a032 Compare October 15, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant