[ui] Fix misc styling / unnecessary overrides following Blueprint update #25241
Conversation
| text-align: left; | ||
| flex: 1; |
There was a problem hiding this comment.
I changed our <Button> label child to be "flex: 1" so that the right icon is always right-justified when a fixed-width or full-width is applied to the button. Looking over a lot of our overrides in Cloud I think this will remove the need for a good chunk of them.
| @@ -15,6 +16,7 @@ interface Props extends Omit<React.ComponentPropsWithRef<'input'>, 'onChange'> { | |||
| export const TextInput = React.forwardRef( | |||
| (props: Props, ref: React.ForwardedRef<HTMLInputElement>) => { | |||
| const { | |||
| fill, | |||
There was a problem hiding this comment.
This is an option on Button and Select and it will allow us to clean up two more custom CSS overrides in Plus -- because there's a container div on line 29 that doesn't take any external styles, it's been difficult to make a full-width input
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 6c0b7c4. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 6c0b7c4. |
bengotow
force-pushed
the
bengotow-2024-10/FE-615
branch
from
4eb7170 to
6c0b7c4
Compare
…ate (dagster-io#25241) ## Summary & Motivation https://linear.app/dagster-labs/issue/FE-615/fix-text-wrapping-issues-in-buttons-on-ui-pages ## How I Tested These Changes Tested these callsites manually in OSS. Co-authored-by: bengotow <[email protected]>
Summary & Motivation
https://linear.app/dagster-labs/issue/FE-615/fix-text-wrapping-issues-in-buttons-on-ui-pages
How I Tested These Changes
Tested these callsites manually in OSS.