Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC-538] guide for writing a multi-asset integration #25260

Merged
merged 12 commits into from
Dec 20, 2024

Conversation

cmpadden
Copy link
Contributor

@cmpadden cmpadden commented Oct 14, 2024

Summary & Motivation

Migration of guide on writing a multi-asset integration to the new docs.

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

Copy link

github-actions bot commented Oct 14, 2024

Deploy preview for dagster-docs-beta ready!

Preview available at https://dagster-docs-beta-nosnevz1s-elementl.vercel.app

Direct link to changed pages:

@PedramNavid PedramNavid self-requested a review October 14, 2024 18:49
@cmpadden cmpadden changed the title [docs,beta] guide for writing a multi-asset integration [DOC-538] guide for writing a multi-asset integration Oct 15, 2024
@cmpadden cmpadden marked this pull request as ready for review October 29, 2024 18:01
@graphite-app graphite-app bot added the area: docs Related to documentation in general label Oct 29, 2024
@cmpadden cmpadden requested a review from neverett November 13, 2024 19:27
@cmpadden
Copy link
Contributor Author

Including you as a reviewer on this one, @neverett , but it's low prio.

Eventually we'll want to have guides on how to write integrations with Dagster, and this was a port of one that I wrote in the legacy docs.

@neverett
Copy link
Contributor

Cross-linking #26323, which reorganizes the integrations section to make space for narrative docs like this.

Copy link
Contributor

@neverett neverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few small editorial suggestions, otherwise this LGTM, thanks!

You'll also need to merge master in and move this doc to docs/integrations/guides -- you can delete the empty multi-asset-integration.md file that's already in there.

docs/docs-beta/docs/tutorial/multi-asset-integration.md Outdated Show resolved Hide resolved
docs/docs-beta/docs/tutorial/multi-asset-integration.md Outdated Show resolved Hide resolved
docs/docs-beta/docs/tutorial/multi-asset-integration.md Outdated Show resolved Hide resolved
docs/docs-beta/docs/tutorial/multi-asset-integration.md Outdated Show resolved Hide resolved
docs/docs-beta/docs/tutorial/multi-asset-integration.md Outdated Show resolved Hide resolved
docs/docs-beta/docs/tutorial/multi-asset-integration.md Outdated Show resolved Hide resolved
docs/docs-beta/docs/tutorial/multi-asset-integration.md Outdated Show resolved Hide resolved
docs/docs-beta/docs/tutorial/multi-asset-integration.md Outdated Show resolved Hide resolved
docs/docs-beta/docs/tutorial/multi-asset-integration.md Outdated Show resolved Hide resolved
docs/docs-beta/docs/tutorial/multi-asset-integration.md Outdated Show resolved Hide resolved
@cmpadden cmpadden merged commit 0113bcc into master Dec 20, 2024
1 of 3 checks passed
@cmpadden cmpadden deleted the colton/docs-beta-multi-asset-integration branch December 20, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants