[1/n] [RFC] relabel test sensors/schedules to 'Evaluate tick' #25300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dliu27
changed the title
|
Deploy preview for dagster-university ready! ✅ Preview Built with commit 3166ab7. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 5d9c29c. |
graphite-app
bot
added
the
area: dagster-university
dliu27
force-pushed
the
dliu27/manual-sensors-oss
branch
from
3166ab7 to
89ff3c9
Compare
dliu27
requested review from
bengotow and
smackesey
and removed request for
PedramNavid,
cmpadden and
C00ldudeNoonan
dliu27
removed
area: docs
dliu27
changed the title
|
I think the only thing is that it's not clear that "Manual tick" is an action. What will happen if I press it? |
bengotow
approved these changes
Oct 21, 2024
dliu27
force-pushed
the
dliu27/manual-sensors-oss
branch
from
89ff3c9 to
d9a3490
Compare
dliu27
force-pushed
the
dliu27/manual-sensors-oss
branch
from
8866f99 to
a39ee99
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
js_modules/dagster-ui/packages/ui-core/src/schedules/ScheduleDetails.tsx
Show resolved
Hide resolved
dliu27
force-pushed
the
dliu27/manual-sensors-oss
branch
from
a39ee99 to
d986a9f
Compare
dliu27
changed the title
dliu27
force-pushed
the
dliu27/manual-sensors-oss
branch
from
d986a9f to
f2b65c1
Compare
dliu27
force-pushed
the
dliu27/manual-sensors-oss
branch
from
f2b65c1 to
5d9c29c
Compare
dliu27
added a commit
that referenced
this pull request
Dec 9, 2024
## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-623/relabel-test-sensorschedule-buttons-to-manual-tick Want to relabel "Test sensor" and "Test schedule" buttons to "Manual Tick" Will refactor all other instances of "Test sensor" and "Test schedule" in Dagster docs in this Linear ticket: https://linear.app/dagster-labs/issue/FE-626/update-dagster-docs-and-screenshots-for-changed-copy   ## How I Tested These Changes Tested locally
dliu27
added a commit
to dliu27/dagster-fork
that referenced
this pull request
Dec 9, 2024
…r-io#25300) ## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-623/relabel-test-sensorschedule-buttons-to-manual-tick Want to relabel "Test sensor" and "Test schedule" buttons to "Manual Tick" Will refactor all other instances of "Test sensor" and "Test schedule" in Dagster docs in this Linear ticket: https://linear.app/dagster-labs/issue/FE-626/update-dagster-docs-and-screenshots-for-changed-copy   ## How I Tested These Changes Tested locally
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
…r-io#25300) ## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-623/relabel-test-sensorschedule-buttons-to-manual-tick Want to relabel "Test sensor" and "Test schedule" buttons to "Manual Tick" Will refactor all other instances of "Test sensor" and "Test schedule" in Dagster docs in this Linear ticket: https://linear.app/dagster-labs/issue/FE-626/update-dagster-docs-and-screenshots-for-changed-copy   ## How I Tested These Changes Tested locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Linear: https://linear.app/dagster-labs/issue/FE-623/relabel-test-sensorschedule-buttons-to-manual-tick
Want to relabel "Test sensor" and "Test schedule" buttons to "Manual Tick"
Will refactor all other instances of "Test sensor" and "Test schedule" in Dagster docs in this Linear ticket: https://linear.app/dagster-labs/issue/FE-626/update-dagster-docs-and-screenshots-for-changed-copy
How I Tested These Changes
Tested locally