Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc 302 new etl tutorial - part 1 #25320

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

C00ldudeNoonan
Copy link
Contributor

Summary & Motivation

I'm a little way into this and would like to get feedback from @PedramNavid and @cmpadden on the structure and general flow. This isn't done at this point, but I figure we could collaborate here and iterate from there.

I made some changes to the reference file to make it more concise regarding metadata output. The new code example function works great.

Main Questions I have at this point:

  1. Where will we put pictures for the new docs site? I want to add some UI screenshots for more color.
  2. How many explanations should I add here? I know on the previous site, the main complaint was that there was too much going on. I think having a couple of sentences explaining a concept is fine, with a link to the main page for that concept/API
  3. Should we hide the code examples and have the user reveal them or leave them as is?

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

@graphite-app graphite-app bot added the area: docs Related to documentation in general label Oct 16, 2024
@dbrtly
Copy link
Contributor

dbrtly commented Oct 17, 2024

I've been looking at pyproject.toml, setup.cfg and setup.py and thinking that could be pyproject.toml only for many projects. Especially for beginner level tutorials.

#25303

@PedramNavid PedramNavid marked this pull request as draft October 18, 2024 03:05
@C00ldudeNoonan
Copy link
Contributor Author

@neverett I think the first portion of the tutorial is ready for your review. Once this section is good I can continue with the rest of the tutorial

@C00ldudeNoonan C00ldudeNoonan marked this pull request as ready for review November 13, 2024 19:44
@C00ldudeNoonan C00ldudeNoonan changed the title Doc 302 new etl tutorial Doc 302 new etl tutorial - part 1 Nov 13, 2024
Copy link
Contributor

@neverett neverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think this is the right level of granularity and selection of topics for people looking to move beyond the Quickstart (esp. if they're somewhat experienced data engineers), and the pacing is good. I left fairly detailed feedback on pages 1 and 2, and high-level feedback for page 3 (asset dependencies and checks), since I think that one is worth splitting into two pages. Once you've taken another pass at the content, I'm happy to re-review and give more feedback on the downstream asset and asset checks content, and other content where it makes sense.

docs/docs-beta/docs/tutorial/02-your-first-asset.md Outdated Show resolved Hide resolved
docs/docs-beta/docs/tutorial/02-your-first-asset.md Outdated Show resolved Hide resolved
docs/docs-beta/docs/tutorial/02-your-first-asset.md Outdated Show resolved Hide resolved
@dbrtly
Copy link
Contributor

dbrtly commented Nov 15, 2024 via email

@dbrtly
Copy link
Contributor

dbrtly commented Nov 15, 2024 via email

Copy link
Contributor

@neverett neverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took another pass through and left some more feedback, let me know what you think! Happy to re-review as you add the remaining pages.

docs/docs-beta/sidebars.ts Outdated Show resolved Hide resolved
@C00ldudeNoonan C00ldudeNoonan marked this pull request as draft December 10, 2024 17:59
@C00ldudeNoonan
Copy link
Contributor Author

@neverett I added the remaining pages, feel free to review them when you get a chance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants