Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] TS, lint updates for ui-components #25322

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

hellendag
Copy link
Member

@hellendag hellendag commented Oct 16, 2024

Summary & Motivation

Update lint config and TS for ui-components, which uses the external npm package as its eslint-config dependency.

How I Tested These Changes

TS, lint, jest. Repeat at dagster-ui level, verify that everything passes.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hellendag and the rest of your teammates on Graphite Graphite

@hellendag hellendag requested review from bengotow and dliu27 October 16, 2024 21:39
@hellendag hellendag marked this pull request as ready for review October 16, 2024 21:39
Copy link

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-dqywncw9y-elementl.vercel.app
https://dish-lint-ts-components.components-storybook.dagster-docs.io

Built with commit 8c0b630.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

@dliu27 dliu27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@hellendag hellendag merged commit c09f8d3 into master Oct 16, 2024
2 checks passed
@hellendag hellendag deleted the dish/lint-ts-components branch October 16, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants