[5/n] [RFC] add launch all frontend functionality for sensors #25633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dliu27
changed the base branch from
master
to
dliu27/add-manual-tick-to-automation-rows
dliu27
force-pushed
the
dliu27/launch-all-backend
branch
2 times, most recently
from
2133f30 to
11722d5
Compare
dliu27
force-pushed
the
dliu27/add-manual-tick-to-automation-rows
branch
from
5cfc7d0 to
7588c11
Compare
salazarm
reviewed
Nov 5, 2024
js_modules/dagster-ui/packages/ui-core/src/launchpad/useLaunchMultipleRunsWithTelemetry.oss.tsx
Outdated
Show resolved
Hide resolved
salazarm
reviewed
Nov 5, 2024
salazarm
reviewed
Nov 5, 2024
js_modules/dagster-ui/packages/ui-core/src/ticks/SensorDryRunDialog.tsx
Outdated
Show resolved
Hide resolved
salazarm
reviewed
Nov 5, 2024
js_modules/dagster-ui/packages/ui-core/src/ticks/SensorDryRunDialog.tsx
Outdated
Show resolved
Hide resolved
salazarm
requested changes
Nov 5, 2024
There was a problem hiding this comment.
Few comments on the JS. The python looks good to me but I defer to @smackesey
dliu27
force-pushed
the
dliu27/launch-all-backend
branch
from
a7032cf to
807f501
Compare
dliu27
force-pushed
the
dliu27/add-manual-tick-to-automation-rows
branch
from
7588c11 to
b711bcc
Compare
dliu27
force-pushed
the
dliu27/launch-all-backend
branch
from
807f501 to
01befea
Compare
dliu27
changed the base branch from
dliu27/add-manual-tick-to-automation-rows
to
dliu27/launch-all-backend-actual
dliu27
force-pushed
the
dliu27/launch-all-backend
branch
from
01befea to
e80659a
Compare
dliu27
changed the title
dliu27
changed the title
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 9a49e59. |
dliu27
changed the title
dliu27
force-pushed
the
dliu27/launch-all-backend-actual
branch
from
db05f4b to
7e104b4
Compare
dliu27
force-pushed
the
dliu27/launch-all-backend
branch
from
e80659a to
f4c0ba7
Compare
dliu27
force-pushed
the
dliu27/launch-all-backend-actual
branch
from
7984ca1 to
0c99f41
Compare
dliu27
force-pushed
the
dliu27/launch-all-backend
branch
2 times, most recently
from
f6d2aa1 to
3859479
Compare
salazarm
reviewed
Nov 21, 2024
dliu27
force-pushed
the
dliu27/launch-all-backend-actual
branch
from
d8479ed to
b8c0353
Compare
dliu27
force-pushed
the
dliu27/launch-all-backend
branch
from
61641db to
4fedf08
Compare
dliu27
force-pushed
the
dliu27/launch-all-backend-actual
branch
from
b8c0353 to
f23944d
Compare
dliu27
force-pushed
the
dliu27/launch-all-backend
branch
from
4fedf08 to
9a49e59
Compare
dliu27
force-pushed
the
dliu27/launch-all-backend-actual
branch
from
f23944d to
ae25771
Compare
dliu27
force-pushed
the
dliu27/launch-all-backend
branch
from
9a49e59 to
d934149
Compare
dliu27
added a commit
that referenced
this pull request
Dec 9, 2024
## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-624/[fe]-implement-launch-all-frontend-sensor Adds the frontend for 'launch all' for manual tick sensors Video: https://github.com/user-attachments/assets/222b35c2-19c7-4bb9-a975-85f9ae56c328 ## How I Tested These Changes yarn ts, lint, make graphql
dliu27
added a commit
to dliu27/dagster-fork
that referenced
this pull request
Dec 9, 2024
…r-io#25633) ## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-624/[fe]-implement-launch-all-frontend-sensor Adds the frontend for 'launch all' for manual tick sensors Video: https://github.com/user-attachments/assets/222b35c2-19c7-4bb9-a975-85f9ae56c328 ## How I Tested These Changes yarn ts, lint, make graphql
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
…r-io#25633) ## Summary & Motivation Linear: https://linear.app/dagster-labs/issue/FE-624/[fe]-implement-launch-all-frontend-sensor Adds the frontend for 'launch all' for manual tick sensors Video: https://github.com/user-attachments/assets/222b35c2-19c7-4bb9-a975-85f9ae56c328 ## How I Tested These Changes yarn ts, lint, make graphql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Linear: https://linear.app/dagster-labs/issue/FE-624/[fe]-implement-launch-all-frontend-sensor
Adds the frontend for 'launch all' for manual tick sensors
Video:
Recording.at.2024-10-29.22.33.38.mp4
How I Tested These Changes
yarn ts, lint, make graphql
Changelog