-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4/n] [RFC] add launch multiple runs backend functionality #25880
Conversation
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit ae25771. |
js_modules/dagster-ui/packages/ui-core/src/graphql/schema.graphql
Outdated
Show resolved
Hide resolved
9e8213d
to
4406df6
Compare
db05f4b
to
7e104b4
Compare
python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_run_launcher.py
Outdated
Show resolved
Hide resolved
python_modules/dagster-graphql/dagster_graphql/schema/roots/mutation.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the output type to be a union of GraphenePythonError, GrapheneUnauthorizedError and GrapheneLaunchMultipleRunsResult
4406df6
to
288ab5a
Compare
7984ca1
to
0c99f41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks solid. fine with removing the GrapheneUnauthorizedError, like we spoke about
70aa695
to
8f561a3
Compare
d8479ed
to
b8c0353
Compare
8f561a3
to
7a38314
Compare
b8c0353
to
f23944d
Compare
7a38314
to
4e845e6
Compare
f23944d
to
ae25771
Compare
Linear: https://linear.app/dagster-labs/issue/FE-659/add-launch-all-backend-functionality ## Summary & Motivation Add a backend GraphQL mutation to handle launching multiple runs ## How I Tested These Changes `pytest python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_run_launcher.py` 50 passed, 18 warnings in 206.16s (0:03:26)
…o#25880) Linear: https://linear.app/dagster-labs/issue/FE-659/add-launch-all-backend-functionality ## Summary & Motivation Add a backend GraphQL mutation to handle launching multiple runs ## How I Tested These Changes `pytest python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_run_launcher.py` 50 passed, 18 warnings in 206.16s (0:03:26)
…o#25880) Linear: https://linear.app/dagster-labs/issue/FE-659/add-launch-all-backend-functionality ## Summary & Motivation Add a backend GraphQL mutation to handle launching multiple runs ## How I Tested These Changes `pytest python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_run_launcher.py` 50 passed, 18 warnings in 206.16s (0:03:26)
Linear: https://linear.app/dagster-labs/issue/FE-659/add-launch-all-backend-functionality
Summary & Motivation
Add a backend GraphQL mutation to handle launching multiple runs
How I Tested These Changes
pytest python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_run_launcher.py
50 passed, 18 warnings in 206.16s (0:03:26)
Changelog