Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4/n] [RFC] add launch multiple runs backend functionality #25880

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

dliu27
Copy link
Contributor

@dliu27 dliu27 commented Nov 12, 2024

Linear: https://linear.app/dagster-labs/issue/FE-659/add-launch-all-backend-functionality

Summary & Motivation

Add a backend GraphQL mutation to handle launching multiple runs

How I Tested These Changes

pytest python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_run_launcher.py
50 passed, 18 warnings in 206.16s (0:03:26)

Changelog

Insert changelog entry or delete this section.

@dliu27 dliu27 requested review from smackesey and salazarm November 12, 2024 18:07
Copy link

github-actions bot commented Nov 12, 2024

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-jaor1etx7-elementl.vercel.app
https://dliu27-launch-all-backend-actual.core-storybook.dagster-docs.io

Built with commit ae25771.
This pull request is being automatically deployed with vercel-action

@dliu27 dliu27 changed the title [4/n] add launch multiple runs backend functionality [4/n] [RFC] add launch multiple runs backend functionality Nov 12, 2024
@dliu27 dliu27 force-pushed the dliu27/add-manual-tick-to-automation-rows branch from 9e8213d to 4406df6 Compare November 13, 2024 18:13
@dliu27 dliu27 force-pushed the dliu27/launch-all-backend-actual branch from db05f4b to 7e104b4 Compare November 13, 2024 18:17
Copy link
Contributor

@salazarm salazarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the output type to be a union of GraphenePythonError, GrapheneUnauthorizedError and GrapheneLaunchMultipleRunsResult

@dliu27 dliu27 requested a review from salazarm November 18, 2024 21:12
@dliu27 dliu27 force-pushed the dliu27/add-manual-tick-to-automation-rows branch from 4406df6 to 288ab5a Compare November 18, 2024 21:22
@dliu27 dliu27 force-pushed the dliu27/launch-all-backend-actual branch from 7984ca1 to 0c99f41 Compare November 18, 2024 21:46
Copy link
Contributor

@salazarm salazarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks solid. fine with removing the GrapheneUnauthorizedError, like we spoke about

@dliu27 dliu27 force-pushed the dliu27/add-manual-tick-to-automation-rows branch 2 times, most recently from 70aa695 to 8f561a3 Compare December 5, 2024 21:33
@dliu27 dliu27 force-pushed the dliu27/launch-all-backend-actual branch from d8479ed to b8c0353 Compare December 5, 2024 21:38
@dliu27 dliu27 force-pushed the dliu27/add-manual-tick-to-automation-rows branch from 8f561a3 to 7a38314 Compare December 6, 2024 15:27
@dliu27 dliu27 force-pushed the dliu27/launch-all-backend-actual branch from b8c0353 to f23944d Compare December 6, 2024 15:28
@dliu27 dliu27 force-pushed the dliu27/add-manual-tick-to-automation-rows branch from 7a38314 to 4e845e6 Compare December 9, 2024 16:23
Base automatically changed from dliu27/add-manual-tick-to-automation-rows to master December 9, 2024 16:47
@dliu27 dliu27 force-pushed the dliu27/launch-all-backend-actual branch from f23944d to ae25771 Compare December 9, 2024 17:38
@dliu27 dliu27 merged commit e8ce050 into master Dec 9, 2024
1 of 2 checks passed
@dliu27 dliu27 deleted the dliu27/launch-all-backend-actual branch December 9, 2024 17:38
dliu27 added a commit that referenced this pull request Dec 9, 2024
Linear:
https://linear.app/dagster-labs/issue/FE-659/add-launch-all-backend-functionality

## Summary & Motivation
Add a backend GraphQL mutation to handle launching multiple runs

## How I Tested These Changes
`pytest
python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_run_launcher.py`
50 passed, 18 warnings in 206.16s (0:03:26)
dliu27 added a commit to dliu27/dagster-fork that referenced this pull request Dec 9, 2024
…o#25880)

Linear:
https://linear.app/dagster-labs/issue/FE-659/add-launch-all-backend-functionality

## Summary & Motivation
Add a backend GraphQL mutation to handle launching multiple runs

## How I Tested These Changes
`pytest
python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_run_launcher.py`
50 passed, 18 warnings in 206.16s (0:03:26)
pskinnerthyme pushed a commit to pskinnerthyme/dagster that referenced this pull request Dec 16, 2024
…o#25880)

Linear:
https://linear.app/dagster-labs/issue/FE-659/add-launch-all-backend-functionality

## Summary & Motivation
Add a backend GraphQL mutation to handle launching multiple runs

## How I Tested These Changes
`pytest
python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_run_launcher.py`
50 passed, 18 warnings in 206.16s (0:03:26)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants