Update callsites of AssetSpec._replace to use replace_attributes #25942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benpankow
force-pushed
the
benpankow/replace-attributes-2
branch
from
66adb9d to
44c54ac
Compare
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-r9sg7h448-elementl.vercel.app Direct link to changed pages: |
benpankow
force-pushed
the
benpankow/replace-attributes
branch
from
5d7fb8c to
e1756ba
Compare
benpankow
force-pushed
the
benpankow/replace-attributes-2
branch
from
44c54ac to
73e87b9
Compare
benpankow
force-pushed
the
benpankow/replace-attributes
branch
from
e1756ba to
5f4b4a9
Compare
benpankow
force-pushed
the
benpankow/replace-attributes-2
branch
from
73e87b9 to
fc5cb2d
Compare
OwenKephart
approved these changes
Nov 15, 2024
benpankow
force-pushed
the
benpankow/replace-attributes-2
branch
2 times, most recently
from
e918ac1 to
29b17e0
Compare
benpankow
force-pushed
the
benpankow/replace-attributes
branch
from
bb94e62 to
04fb74c
Compare
benpankow
force-pushed
the
benpankow/replace-attributes-2
branch
from
29b17e0 to
d7dd7de
Compare
benpankow
force-pushed
the
benpankow/replace-attributes
branch
from
04fb74c to
8634ced
Compare
benpankow
force-pushed
the
benpankow/replace-attributes-2
branch
2 times, most recently
from
261c2ab to
af734cb
Compare
benpankow
force-pushed
the
benpankow/replace-attributes-2
branch
4 times, most recently
from
2d5a235 to
ec04eb6
Compare
benpankow
force-pushed
the
benpankow/replace-attributes-2
branch
from
ec04eb6 to
3e8566d
Compare
cmpadden
pushed a commit
that referenced
this pull request
Dec 5, 2024
) ## Summary Follow-on to #25941 which updates some non-type-checked `_replace` callsites to use these new methods.
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
…ster-io#25942) ## Summary Follow-on to dagster-io#25941 which updates some non-type-checked `_replace` callsites to use these new methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-on to #25941 which updates some non-type-checked
_replacecallsites to use these new methods.