-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dagster-airlift][cleanup] Move airlift to python_modules #26021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-4cpik0mwb-elementl.vercel.app Direct link to changed pages: |
Graphite Automations"Add a 'docs-to-migrate' label to PRs with docs" took an action on this PR • (11/20/24)1 label was added to this PR based on Christopher DeCarolis's automation. |
This was referenced Nov 20, 2024
dpeng817
force-pushed
the
dpeng817/move_airlift
branch
2 times, most recently
from
November 20, 2024 00:59
b244be5
to
bc95a34
Compare
dpeng817
changed the title
[dagster-airlift] Move airlift to python_modules
[dagster-airlift][cleanup] Move airlift to python_modules
Nov 20, 2024
dpeng817
force-pushed
the
dpeng817/move_airlift
branch
from
November 20, 2024 16:50
bc95a34
to
955d66d
Compare
OwenKephart
approved these changes
Nov 20, 2024
Base automatically changed from
dpeng817/federation_tutorial_mirroring
to
master
November 20, 2024 23:45
dpeng817
force-pushed
the
dpeng817/move_airlift
branch
from
November 20, 2024 23:51
955d66d
to
66d3639
Compare
dpeng817
force-pushed
the
dpeng817/move_airlift
branch
from
November 21, 2024 00:35
72061fb
to
0765966
Compare
dpeng817
added a commit
that referenced
this pull request
Nov 21, 2024
## Summary & Motivation Moves airlift to the python_modules/libraries directory. Matches other top-level packages, means that it becomes part of the standard release process. This change required some legitimate changes to get the build to pass: - reformatting proxied yaml files - switching imports from relative to explicit - fix the MANIFEST.in file which was totally busted before - move py.typed to the `dagster_airlift` subdirectory. This PR will be used as an accumulator for all the PRs prefixed with [cleanup]
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
…#26021) ## Summary & Motivation Moves airlift to the python_modules/libraries directory. Matches other top-level packages, means that it becomes part of the standard release process. This change required some legitimate changes to get the build to pass: - reformatting proxied yaml files - switching imports from relative to explicit - fix the MANIFEST.in file which was totally busted before - move py.typed to the `dagster_airlift` subdirectory. This PR will be used as an accumulator for all the PRs prefixed with [cleanup]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Moves airlift to the python_modules/libraries directory. Matches other top-level packages, means that it becomes part of the standard release process.
This change required some legitimate changes to get the build to pass:
dagster_airlift
subdirectory.This PR will be used as an accumulator for all the PRs prefixed with [cleanup]