Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-airlift][cleanup] Move airlift to python_modules #26021

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

dpeng817
Copy link
Contributor

@dpeng817 dpeng817 commented Nov 20, 2024

Summary & Motivation

Moves airlift to the python_modules/libraries directory. Matches other top-level packages, means that it becomes part of the standard release process.

This change required some legitimate changes to get the build to pass:

  • reformatting proxied yaml files
  • switching imports from relative to explicit
  • fix the MANIFEST.in file which was totally busted before
  • move py.typed to the dagster_airlift subdirectory.

This PR will be used as an accumulator for all the PRs prefixed with [cleanup]

@dpeng817 dpeng817 requested a review from benpankow November 20, 2024 00:07
@dpeng817 dpeng817 marked this pull request as ready for review November 20, 2024 00:07
@dpeng817 dpeng817 requested a review from neverett as a code owner November 20, 2024 00:07
@graphite-app graphite-app bot added the docs-to-migrate Docs to migrate to new docs site label Nov 20, 2024
Copy link

graphite-app bot commented Nov 20, 2024

Graphite Automations

"Add a 'docs-to-migrate' label to PRs with docs" took an action on this PR • (11/20/24)

1 label was added to this PR based on Christopher DeCarolis's automation.

@dpeng817 dpeng817 force-pushed the dpeng817/move_airlift branch 2 times, most recently from b244be5 to bc95a34 Compare November 20, 2024 00:59
@dpeng817 dpeng817 changed the title [dagster-airlift] Move airlift to python_modules [dagster-airlift][cleanup] Move airlift to python_modules Nov 20, 2024
@dpeng817 dpeng817 force-pushed the dpeng817/move_airlift branch from bc95a34 to 955d66d Compare November 20, 2024 16:50
Base automatically changed from dpeng817/federation_tutorial_mirroring to master November 20, 2024 23:45
@dpeng817 dpeng817 force-pushed the dpeng817/move_airlift branch from 955d66d to 66d3639 Compare November 20, 2024 23:51
@dpeng817 dpeng817 force-pushed the dpeng817/move_airlift branch from 72061fb to 0765966 Compare November 21, 2024 00:35
@dpeng817 dpeng817 merged commit ca745c6 into master Nov 21, 2024
1 of 3 checks passed
@dpeng817 dpeng817 deleted the dpeng817/move_airlift branch November 21, 2024 01:18
dpeng817 added a commit that referenced this pull request Nov 21, 2024
## Summary & Motivation
Moves airlift to the python_modules/libraries directory. Matches other
top-level packages, means that it becomes part of the standard release
process.

This change required some legitimate changes to get the build to pass:
- reformatting proxied yaml files
- switching imports from relative to explicit
- fix the MANIFEST.in file which was totally busted before
- move py.typed to the `dagster_airlift` subdirectory.

This PR will be used as an accumulator for all the PRs prefixed with
[cleanup]
pskinnerthyme pushed a commit to pskinnerthyme/dagster that referenced this pull request Dec 16, 2024
…#26021)

## Summary & Motivation
Moves airlift to the python_modules/libraries directory. Matches other
top-level packages, means that it becomes part of the standard release
process.

This change required some legitimate changes to get the build to pass:
- reformatting proxied yaml files
- switching imports from relative to explicit
- fix the MANIFEST.in file which was totally busted before
- move py.typed to the `dagster_airlift` subdirectory.

This PR will be used as an accumulator for all the PRs prefixed with
[cleanup]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-to-migrate Docs to migrate to new docs site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants