[dagster-tableau] Use get_asset_spec().key in DagsterTableauTranslator #26027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 20, 2024
benpankow
approved these changes
Nov 20, 2024
maximearmstrong
force-pushed
the
maxime/use-get-asset-spec-key-in-tableau-translator
branch
from
7c1d54d to
c274578
Compare
maximearmstrong
force-pushed
the
maxime/use-get-asset-spec-key-in-tableau-translator
branch
from
c274578 to
3e70494
Compare
maximearmstrong
deleted the
maxime/use-get-asset-spec-key-in-tableau-translator
branch
cmpadden
pushed a commit
that referenced
this pull request
Dec 5, 2024
#26027) ## Summary & Motivation Following an internal discussion [here](dagster-io/internal#12670) and product review [here](https://www.notion.so/dagster/Product-Reviews-1805443bfd5d4d40b3f6be8c79897295?p=13f18b92e4628020bd6fd3ac45f28af0&pm=s), get_asset_spec().key is the new recommended way to access the asset key in the Translator. Asset keys can now be customized in a custom translator using `replace_attributes`, like: ```python class MyCustomTableauTranslator(DagsterTableauTranslator): def get_asset_spec(self, data: TableauContentData) -> dg.AssetSpec: default_spec = super().get_asset_spec(data) return replace_attributes( default_spec, key=default_spec.key.with_prefix("prefix"), ) ``` This PR stack will be merged after #25941 lands, so that `replace_attributes()` can be called as `AssetSpec().replace_attributes()` These changes will also be done to the following integrations: - Power BI - Sigma - Looker - dlt - Sling - sdf We will need to rework dbt to use this pattern. ## How I Tested These Changes Updated unit test with BK
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
dagster-io#26027) ## Summary & Motivation Following an internal discussion [here](https://github.com/dagster-io/internal/discussions/12670) and product review [here](https://www.notion.so/dagster/Product-Reviews-1805443bfd5d4d40b3f6be8c79897295?p=13f18b92e4628020bd6fd3ac45f28af0&pm=s), get_asset_spec().key is the new recommended way to access the asset key in the Translator. Asset keys can now be customized in a custom translator using `replace_attributes`, like: ```python class MyCustomTableauTranslator(DagsterTableauTranslator): def get_asset_spec(self, data: TableauContentData) -> dg.AssetSpec: default_spec = super().get_asset_spec(data) return replace_attributes( default_spec, key=default_spec.key.with_prefix("prefix"), ) ``` This PR stack will be merged after dagster-io#25941 lands, so that `replace_attributes()` can be called as `AssetSpec().replace_attributes()` These changes will also be done to the following integrations: - Power BI - Sigma - Looker - dlt - Sling - sdf We will need to rework dbt to use this pattern. ## How I Tested These Changes Updated unit test with BK
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
…agster-io#26035) ## Summary & Motivation Like dagster-io#26027 but for Sigma ## How I Tested These Changes Updated unit test with BK
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
dagster-io#26051) ## Summary & Motivation Like dagster-io#26027 but for Power BI ## How I Tested These Changes Updated unit test with BK
pskinnerthyme
pushed a commit
to pskinnerthyme/dagster
that referenced
this pull request
Dec 16, 2024
…or (dagster-io#26048) ## Summary & Motivation Like dagster-io#26027 but for Looker API ## How I Tested These Changes Updated unit test with BK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Following an internal discussion here and product review here, get_asset_spec().key is the new recommended way to access the asset key in the Translator.
Asset keys can now be customized in a custom translator using
replace_attributes, like:This PR stack will be merged after #25941 lands, so that
replace_attributes()can be called asAssetSpec().replace_attributes()These changes will also be done to the following integrations:
We will need to rework dbt to use this pattern.
How I Tested These Changes
Updated unit test with BK