Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6/n] [RFC] add launch all frontend functionality for schedules #26063

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

dliu27
Copy link
Contributor

@dliu27 dliu27 commented Nov 20, 2024

Summary & Motivation

Linear: https://linear.app/dagster-labs/issue/FE-654/[fe]-implement-launch-all-frontend-schedule

Adds the frontend for 'launch all' for manual tick schedules

Video:

Recording.at.2024-11-20.17.50.18.mp4

How I Tested These Changes

tested the launch all runs flow locally

yarn lint, ts, jest, generate-graphql in ui-core

Changelog

@dliu27 dliu27 requested review from salazarm and hellendag November 20, 2024 22:47
Copy link

github-actions bot commented Nov 20, 2024

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-8ld76u2n8-elementl.vercel.app
https://dliu27-launch-all-schedules.core-storybook.dagster-docs.io

Built with commit 78fbf1b.
This pull request is being automatically deployed with vercel-action

@dliu27 dliu27 force-pushed the dliu27/launch-all-schedules branch from d90bb7e to bd4f13a Compare November 21, 2024 19:53
@dliu27 dliu27 requested a review from salazarm November 22, 2024 18:52
Copy link
Contributor

@salazarm salazarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@dliu27 dliu27 force-pushed the dliu27/launch-all-backend branch from 61641db to 4fedf08 Compare December 5, 2024 21:42
@dliu27 dliu27 force-pushed the dliu27/launch-all-schedules branch from bd4f13a to 6e428ee Compare December 5, 2024 21:43
@dliu27 dliu27 force-pushed the dliu27/launch-all-backend branch from 4fedf08 to 9a49e59 Compare December 6, 2024 15:28
@dliu27 dliu27 force-pushed the dliu27/launch-all-schedules branch from 6e428ee to 2841172 Compare December 6, 2024 15:39
@dliu27 dliu27 force-pushed the dliu27/launch-all-backend branch from 9a49e59 to d934149 Compare December 9, 2024 17:39
Base automatically changed from dliu27/launch-all-backend to master December 9, 2024 17:40
@dliu27 dliu27 force-pushed the dliu27/launch-all-schedules branch from 2841172 to 78fbf1b Compare December 9, 2024 17:41
@dliu27 dliu27 merged commit 3b5ee74 into master Dec 9, 2024
1 of 2 checks passed
@dliu27 dliu27 deleted the dliu27/launch-all-schedules branch December 9, 2024 17:41
dliu27 added a commit that referenced this pull request Dec 9, 2024
## Summary & Motivation
Linear:
https://linear.app/dagster-labs/issue/FE-654/[fe]-implement-launch-all-frontend-schedule

Adds the frontend for 'launch all' for manual tick schedules

Video:


https://github.com/user-attachments/assets/1d3a9315-cc05-4142-8964-5e86e077403b


## How I Tested These Changes
tested the launch all runs flow locally

yarn lint, ts, jest, generate-graphql in ui-core
dliu27 added a commit to dliu27/dagster-fork that referenced this pull request Dec 9, 2024
…ter-io#26063)

## Summary & Motivation
Linear:
https://linear.app/dagster-labs/issue/FE-654/[fe]-implement-launch-all-frontend-schedule

Adds the frontend for 'launch all' for manual tick schedules

Video:


https://github.com/user-attachments/assets/1d3a9315-cc05-4142-8964-5e86e077403b


## How I Tested These Changes
tested the launch all runs flow locally

yarn lint, ts, jest, generate-graphql in ui-core
pskinnerthyme pushed a commit to pskinnerthyme/dagster that referenced this pull request Dec 16, 2024
…ter-io#26063)

## Summary & Motivation
Linear:
https://linear.app/dagster-labs/issue/FE-654/[fe]-implement-launch-all-frontend-schedule

Adds the frontend for 'launch all' for manual tick schedules

Video:


https://github.com/user-attachments/assets/1d3a9315-cc05-4142-8964-5e86e077403b


## How I Tested These Changes
tested the launch all runs flow locally

yarn lint, ts, jest, generate-graphql in ui-core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants