Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize new Dagster+ docs #26067

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Nov 20, 2024

Merge this PR, then merge #26019.

Summary & Motivation

Reorganizes docs in /dagster-plus to make it easier to port content from old docs. See #26019 for a more detailed description of the motivation -- many of the changes here are similar to changes in that PR.

How I Tested These Changes

Tested locally.

Changelog

Insert changelog entry or delete this section.

Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
@neverett neverett self-assigned this Nov 21, 2024
@neverett neverett added the area:docs-revamp Related to the revamp of the docs label Nov 21, 2024
@neverett neverett changed the title Reorganize Dagster+ docs Reorganize new Dagster+ docs Dec 3, 2024
@neverett neverett marked this pull request as ready for review December 3, 2024 03:03
@neverett neverett requested a review from cmpadden December 3, 2024 03:03
@cmpadden
Copy link
Contributor

cmpadden commented Dec 3, 2024

Deployment appears to be failing due to unrelated issue in API docs build; should not be a blocker for this PR.

scripts/vercel-sync-api-docs.sh: line 16: /vercel/.cargo/env: No such file or directory

Copy link
Contributor

@cmpadden cmpadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Ran it locally and the sidebar felt intuitive.

cmpadden and others added 7 commits December 3, 2024 12:05
## Summary & Motivation

## How I Tested These Changes

## Changelog

> Insert changelog entry or delete this section.
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Copy link

github-actions bot commented Dec 3, 2024

Deploy preview for dagster-docs-beta ready!

Preview available at https://dagster-docs-beta-q22hfmlav-elementl.vercel.app

Direct link to changed pages:

@neverett
Copy link
Contributor Author

neverett commented Dec 3, 2024

Buildkite and Vale failures appear to be unrelated to changes I made in this PR. Going to go ahead and merge this now that the docs build is finally succeeding.

@neverett neverett merged commit d41107b into nikki/docs/reorganize-guides-new-docs Dec 3, 2024
1 of 3 checks passed
@neverett neverett deleted the nikki/docs/reorganize-dagster-plus-new-docs branch December 3, 2024 22:16
neverett added a commit that referenced this pull request Dec 5, 2024
**NOTE:** Merge #26067 before
merging this PR.

## Summary & Motivation

I'm a fair way through auditing old and new docs content, and have
started working on figuring out how to plug the remaining gaps in new
docs. To that end, I reorganized the /guides section of new docs to make
it easier to move old content to the new site.

Big changes I made in this PR:

* Moved docs from the `concepts` directory into `guides` subdirectories
(`automate`, `build`, `deploy`, `monitor`, `test`). The `guides` docs
already contain a lot of conceptual content; the distinction between
`concepts` and `guides` seemed fairly arbitrary and not helpful for
readers.
* Added a top-level glossary page that can serve as a quick reference to
documentation about key concepts, so we don't lose that aspect of having
a separate concepts section. (This is currently an unlisted draft page
that will be finished after more content has been moved over.)
* Updated information architecture:
* Moved docs into a directory structure that mirrors the information
architecture of the website/URL structure to make it easier for readers
to orient themselves in the docs and for contributors to reason about
where to put stuff.
* Added index pages to docs subsections so support engineerins, SEs, and
others can send users and customers links to logical chunks of
information.
* Updated `sidebars.ts` to use autogenerated navigation whenever
possible. This will hopefully make contributing to docs a little easier
-- if someone adds a new page to a section, they don't need to go into
`sidebars.ts` and manually add the page name to its section to make it
visible. (Entire new sections do need to be added manually, though.)
* Used `sidebar_position` in the front matter to organize the position
of docs in the sidebar. Index pages use multiples of 10, while pages use
multiples of 100. This give us a bit of space between sections and pages
to add content as needed.

## How I Tested These Changes

Local build.

## Changelog

Updated beta docs directory structure, added index pages to subsections,
updated page positioning via sidebars.ts and sidebar_position in page
front matter, removed references section and moved YAML reference docs
to guides/deploy.

---------

Signed-off-by: nikki everett <[email protected]>
Co-authored-by: colton <[email protected]>
cmpadden added a commit that referenced this pull request Dec 5, 2024
**NOTE:** Merge #26067 before
merging this PR.

## Summary & Motivation

I'm a fair way through auditing old and new docs content, and have
started working on figuring out how to plug the remaining gaps in new
docs. To that end, I reorganized the /guides section of new docs to make
it easier to move old content to the new site.

Big changes I made in this PR:

* Moved docs from the `concepts` directory into `guides` subdirectories
(`automate`, `build`, `deploy`, `monitor`, `test`). The `guides` docs
already contain a lot of conceptual content; the distinction between
`concepts` and `guides` seemed fairly arbitrary and not helpful for
readers.
* Added a top-level glossary page that can serve as a quick reference to
documentation about key concepts, so we don't lose that aspect of having
a separate concepts section. (This is currently an unlisted draft page
that will be finished after more content has been moved over.)
* Updated information architecture:
* Moved docs into a directory structure that mirrors the information
architecture of the website/URL structure to make it easier for readers
to orient themselves in the docs and for contributors to reason about
where to put stuff.
* Added index pages to docs subsections so support engineerins, SEs, and
others can send users and customers links to logical chunks of
information.
* Updated `sidebars.ts` to use autogenerated navigation whenever
possible. This will hopefully make contributing to docs a little easier
-- if someone adds a new page to a section, they don't need to go into
`sidebars.ts` and manually add the page name to its section to make it
visible. (Entire new sections do need to be added manually, though.)
* Used `sidebar_position` in the front matter to organize the position
of docs in the sidebar. Index pages use multiples of 10, while pages use
multiples of 100. This give us a bit of space between sections and pages
to add content as needed.

## How I Tested These Changes

Local build.

## Changelog

Updated beta docs directory structure, added index pages to subsections,
updated page positioning via sidebars.ts and sidebar_position in page
front matter, removed references section and moved YAML reference docs
to guides/deploy.

---------

Signed-off-by: nikki everett <[email protected]>
Co-authored-by: colton <[email protected]>
pskinnerthyme pushed a commit to pskinnerthyme/dagster that referenced this pull request Dec 16, 2024
**NOTE:** Merge dagster-io#26067 before
merging this PR.

## Summary & Motivation

I'm a fair way through auditing old and new docs content, and have
started working on figuring out how to plug the remaining gaps in new
docs. To that end, I reorganized the /guides section of new docs to make
it easier to move old content to the new site.

Big changes I made in this PR:

* Moved docs from the `concepts` directory into `guides` subdirectories
(`automate`, `build`, `deploy`, `monitor`, `test`). The `guides` docs
already contain a lot of conceptual content; the distinction between
`concepts` and `guides` seemed fairly arbitrary and not helpful for
readers.
* Added a top-level glossary page that can serve as a quick reference to
documentation about key concepts, so we don't lose that aspect of having
a separate concepts section. (This is currently an unlisted draft page
that will be finished after more content has been moved over.)
* Updated information architecture:
* Moved docs into a directory structure that mirrors the information
architecture of the website/URL structure to make it easier for readers
to orient themselves in the docs and for contributors to reason about
where to put stuff.
* Added index pages to docs subsections so support engineerins, SEs, and
others can send users and customers links to logical chunks of
information.
* Updated `sidebars.ts` to use autogenerated navigation whenever
possible. This will hopefully make contributing to docs a little easier
-- if someone adds a new page to a section, they don't need to go into
`sidebars.ts` and manually add the page name to its section to make it
visible. (Entire new sections do need to be added manually, though.)
* Used `sidebar_position` in the front matter to organize the position
of docs in the sidebar. Index pages use multiples of 10, while pages use
multiples of 100. This give us a bit of space between sections and pages
to add content as needed.

## How I Tested These Changes

Local build.

## Changelog

Updated beta docs directory structure, added index pages to subsections,
updated page positioning via sidebars.ts and sidebar_position in page
front matter, removed references section and moved YAML reference docs
to guides/deploy.

---------

Signed-off-by: nikki everett <[email protected]>
Co-authored-by: colton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs-revamp Related to the revamp of the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants